> On July 12, 2016, 3:46 p.m., Andrew Onischuk wrote:
> > Ship It!
> 
> Andrew Onischuk wrote:
>     We have tests for those scripts. Are you sure they pass with your changes?

Thank you for reviewing. I'm afraid I didn't check that. I'll check it soon and 
update. Sorry for that.


- Masahiro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49935/#review141861
-----------------------------------------------------------


On July 12, 2016, 9:19 a.m., Masahiro Tanaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49935/
> -----------------------------------------------------------
> 
> (Updated July 12, 2016, 9:19 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, jun aoki, and Myroslav 
> Papirkovskyy.
> 
> 
> Bugs: AMBARI-17633
>     https://issues.apache.org/jira/browse/AMBARI-17633
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When installing YARN+MapReduce2, I got a WARN message in nodemanager log(in 
> Log Search View) like below
> ```
> 2016-07-09 06:30:21,865 WARN logaggregation.LogAggregationService 
> LogAggregationService.java:230 - Remote Root Log Dir [/app-logs] already 
> exist, but with incorrect permissions. Expected: [rwxrwxrwt], Found: 
> [rwxrwxrwx]. The cluster may have problems with multiple users. 
> ```
> I think the cause of this WARN is 
> [this](https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py#L115).
> We should add stickybit to yarn.nodemanager.remote-app-log-dir.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
>  ce312e0 
> 
> Diff: https://reviews.apache.org/r/49935/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test && manual test
> 
> I think Hadoop QA result is unrelated to this patch
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Reply via email to