----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49826/#review142210 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java (line 313) <https://reviews.apache.org/r/49826/#comment207769> In ```State.isValidStateTransition``` and ```ServiceComponentHostImpl.daemonStateMachineFactory``` the DISABLED state can be reached from INSTALLED state. Should we consider here DISABLED state as well? Or not as on the state transition to DISABLE the KerberosHelperImpl would never be called. - Sebastian Toader On July 13, 2016, 10:33 p.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49826/ > ----------------------------------------------------------- > > (Updated July 13, 2016, 10:33 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, > and Sebastian Toader. > > > Bugs: AMBARI-17629 > https://issues.apache.org/jira/browse/AMBARI-17629 > > > Repository: ambari > > > Description > ------- > > When adding new services and components to a cluster that was initially > created via Blueprints (rather than via the Ambari UI), auth-to-local rules > that are expected to be created as indicated by the Kerberos descriptor are > not. > > It occurs because the components being installed are in the `INIT` state > where the logic to determine whether to include the new auth-to-local rules > or not expects the components to be in either the `INSTALLED` or `STARTED` > states. This is due to logic added when resolving AMBARI-14232. > > #Solution: > Update logic building auth-to-local rules to occur when new services and > components are added to the cluster. Logic assumes caller passes around > explict lists of currently installed services and component (including added > components), previously installed services and components, and a filter to > indicate which services and components are newly added. > > This data will help avoid generating regressions for AMBARI-14232 and > AMBARI-14506 > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 872ec2d > > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java > 8170f17 > > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java > cc48240 > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java > f70c546 > > ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java > 88f0e3c > > ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java > 66ed68d > > ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterConfigurationRequestTest.java > 58919b9 > > Diff: https://reviews.apache.org/r/49826/diff/ > > > Testing > ------- > > Manually tested using various Blueprint and UI-based scenarios. > > # Local unit tests: > > Tests run: 4536, Failures: 0, Errors: 0, Skipped: 34 > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 1:12:50.002s > [INFO] Finished at: Wed Jul 13 13:33:27 EDT 2016 > [INFO] Final Memory: 61M/1918M > [INFO] > ------------------------------------------------------------------------ > > # Jenkins unit tests: PENDING > > > Thanks, > > Robert Levas > >
