----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49995/#review142260 -----------------------------------------------------------
Fix it, then Ship it! ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/split_points.py (line 108) <https://reviews.apache.org/r/49995/#comment207806> Can you leave a comment of 15% implicity give to MRM, not clear if you look at the percentages. - Sid Wagle On July 14, 2016, 5:59 p.m., Aravindan Vijayan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49995/ > ----------------------------------------------------------- > > (Updated July 14, 2016, 5:59 p.m.) > > > Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-17695 > https://issues.apache.org/jira/browse/AMBARI-17695 > > > Repository: ambari > > > Description > ------- > > Use hbase.regionserver.global.memstore.upperLimit instead of lowerLimit for > available memory for split points calculation. > > Change default region counts for METRIC_RECORD and METRIC_AGGREGATE to 2. > > > Diffs > ----- > > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java > b86f97a > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/split_points.py > fa4deaf > ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py > 86bf14d > > Diff: https://reviews.apache.org/r/49995/diff/ > > > Testing > ------- > > Manually tested. > > > Thanks, > > Aravindan Vijayan > >