-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49838/
-----------------------------------------------------------

(Updated July 14, 2016, 10:21 p.m.)


Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako.


Changes
-------

* Applied a workaround for a bug 
(http://stackoverflow.com/questions/21369752/safari-positionfixed-doesnt-breaks-element-from-scope/21440899#21440899)
 in Safari. 
* Removed top and bottom scroll buttons to enable auto-scrolling.
* Displaying sub-menu popup with respect to the window height.
* Added Firefox specific styles to be consistent across all browsers.
* Handled sub-menu display manually instead of using the twitter bootstrap 
framework.
* Refactored code.
* Ambari web test passed
  29021 tests complete (25 seconds)
  154 tests pending
* Manual testing done in the latest versions of Google Chrome, Mozilla Firefox 
and Safari.


Bugs: AMBARI-17636
    https://issues.apache.org/jira/browse/AMBARI-17636


Repository: ambari


Description
-------

* Go to Service->Configs page (that have more than ~ 30 versions)
* Open versions dropdown

*Result:*
Number of visible versions limited by window height.


Diffs (updated)
-----

  ambari-web/app/styles/config_history_flow.less fff3151 
  ambari-web/app/templates/common/configs/config_history_dropdown_row.hbs 
PRE-CREATION 
  ambari-web/app/templates/common/configs/config_history_flow.hbs 73d6913 
  ambari-web/app/views/common/configs/config_history_flow.js ad2b1ab 

Diff: https://reviews.apache.org/r/49838/diff/


Testing
-------

Local Ambari web test passed.
28944 tests complete (25 seconds)
154 tests pending
Manual testing done.


Thanks,

Vivek Ratnavel Subramanian

Reply via email to