----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50140/#review142687 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigAction.java (line 65) <https://reviews.apache.org/r/50140/#comment208319> This should never be null. If it was null, then m_clusters above it would also be null and you'd get a NPE even before here. ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigAction.java (lines 79 - 87) <https://reviews.apache.org/r/50140/#comment208316> Out of curiousity, would it be easier to just read the values from the JSON file directly? That way you don't have to duplicate it here? ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigAction.java (line 91) <https://reviews.apache.org/r/50140/#comment208317> It already exists, so you can just call merge() on it. ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigAction.java (line 103) <https://reviews.apache.org/r/50140/#comment208318> Remove and log instead. ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigAction.java (lines 106 - 107) <https://reviews.apache.org/r/50140/#comment208320> This can't happen. ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigActionTest.java (lines 82 - 83) <https://reviews.apache.org/r/50140/#comment208313> If this test class is in the same package, you should be able to access these directly. - Jonathan Hurley On July 18, 2016, 11:45 a.m., Gautam Borad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50140/ > ----------------------------------------------------------- > > (Updated July 18, 2016, 11:45 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Mahadev > Konar, Sumit Mohanty, Selvamohan Neethiraj, Srimanth Gunturi, and Velmurugan > Periasamy. > > > Bugs: AMBARI-17771 > https://issues.apache.org/jira/browse/AMBARI-17771 > > > Repository: ambari > > > Description > ------- > > Update alert definition URI after stack is updated. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigAction.java > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml > 7be5a1915c00853b2817b815124752063222d59d > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml > 47d9fdb999ef6e7051bd339502e98d30b7c53fc2 > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml > 2daa9b8907aa8159829b40007ec2ae81ffcdb29c > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml > dd7a87f72d1cbbbc9db6027af6c61292743a133a > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigActionTest.java > PRE-CREATION > > ambari-server/src/test/resources/stacks/HDP/2.5.0/services/RANGER/alerts.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/50140/diff/ > > > Testing > ------- > > Tested on a centos 6 cluster after upgrade and checked that the alert works > fine for Ranger Admin. > > > Thanks, > > Gautam Borad > >
