-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50180/
-----------------------------------------------------------
Review request for Ambari, Aravindan Vijayan, Sriharsha Chintalapani, and Sid
Wagle.
Bugs: AMBARI-17784
https://issues.apache.org/jira/browse/AMBARI-17784
Repository: ambari
Description
-------
This is follow-up issue for AMBARI-17725.
After AMBARI-17725, we can distinguish cluster metrics and topology metrics,
which makes us possible to topology name and component name as variables for
templatized dashboard.
But kafkaOffset metrics still have kafka topic and partition information to
middle of metric name which make us hard to pick. Since worker host and worker
port, and task id is not needed for kafkaOffset metrics, we can get rid of
those things from only kafkaOffset metrics.
> topology level
* Before applying: topology.kafka-topology.kafka-spout.<worker
host>.6700.14.kafkaOffset.myKafkaTopic/totalSpoutLag
* After applying: topology.kafka-topology.kafka-topic.myKafkaTopic.totalSpoutLag
> partition level
* Before applying: topology.kafka-topology.kafka-spout.<worker
host>.6700.14.kafkaOffset.myKafkaTopic/partition-5/earliestTimeOffset
* After applying:
topology.kafka-topology.kafka-topic.myKafkaTopic.partition-5.earliestTimeOffset
Diffs
-----
ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
9e6cc98
ambari-metrics/ambari-metrics-storm-sink-legacy/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
271c11f
ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
dcc3192
ambari-metrics/ambari-metrics-storm-sink/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
c76197b
Diff: https://reviews.apache.org/r/50180/diff/
Testing
-------
* Unit test succeed (@ignore is added for trunk. it succeed for branch 2.4)
* Tested manually
Thanks,
Jungtaek Lim
