> On July 18, 2016, 3:57 p.m., Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java, > > line 76 > > <https://reviews.apache.org/r/49891/diff/2/?file=1444834#file1444834line76> > > > > Important to docuemnt why this is needed.
Done. > On July 18, 2016, 3:57 p.m., Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java, > > line 513 > > <https://reviews.apache.org/r/49891/diff/2/?file=1444834#file1444834line513> > > > > Remianing comment about why it is on a separate thread is still > > relevant. Done. - Eugene ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49891/#review142569 ----------------------------------------------------------- On July 19, 2016, 10:54 a.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49891/ > ----------------------------------------------------------- > > (Updated July 19, 2016, 10:54 a.m.) > > > Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Myroslav > Papirkovskyy, and Sid Wagle. > > > Bugs: AMBARI-17651 > https://issues.apache.org/jira/browse/AMBARI-17651 > > > Repository: ambari > > > Description > ------- > > Restart indicator is not shown after modifying the configs. > Test case modified the hdfs config 'Namenode new generation size'. But still > after saving the configuration, restart icon is not shown. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/annotations/TransactionalLock.java > 5934f5a > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java > 94a8fe0 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java > d4e3828 > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java > 51435fe > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java > 92ec843 > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > fdb997b > > ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java > 666111b > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProviderTest.java > dc8017a > > ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java > 9d2fea5 > > Diff: https://reviews.apache.org/r/49891/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Dmitro Lisnichenko > >