> On July 15, 2016, 3:08 p.m., Nate Cole wrote: > > ambari-logsearch/docker/test-logs/zookeeper/zookeeper-test-log.log, lines > > 1-3 > > <https://reviews.apache.org/r/50069/diff/2/?file=1444904#file1444904line1> > > > > Checking in a log file? > > Oliver Szabo wrote: > That is a test file for log processing. I would like to extends the log > examples later (so add much more to validate log parsing is work on the > examples). I could rename them to .txt if it can confuse others
No need - I was only getting clarification why a log file was getting checked in. > On July 15, 2016, 3:08 p.m., Nate Cole wrote: > > ambari-logsearch/docker/test-logs/logsearch/logsearch-test-log.json, line 1 > > <https://reviews.apache.org/r/50069/diff/2/?file=1444903#file1444903line1> > > > > formatting required (it's only a test file, but still) > > Oliver Szabo wrote: > logsearch-test-log.json is also a log file in json format (its easier to > process for logfeeder), we have a specific appender to generate json log > files. Currently these are processed per lines, so that is the reason why its > not formatted. (that is how the custom appened generates them, but of course > later we can fix that behavior) LogFeeder should work the same whether it's formatted or not. - Nate ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50069/#review142389 ----------------------------------------------------------- On July 19, 2016, 7:23 a.m., Oliver Szabo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50069/ > ----------------------------------------------------------- > > (Updated July 19, 2016, 7:23 a.m.) > > > Review request for Ambari, Jonathan Hurley, Dharmesh Makwana, Miklos Gergely, > Nate Cole, Robert Nettleton, Sumit Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-17723 > https://issues.apache.org/jira/browse/AMBARI-17723 > > > Repository: ambari > > > Description > ------- > > Add abillity to setup a qucik dev env for docker with debug capabilities. > Goals: > - setup an env quickly without Ambari (logsearch + logfeeder + solr) > - later create integration test framework based on that (junit/jbehave > managed containers, pinging solr for results etc.) > > > Diffs > ----- > > ambari-logsearch/README.md 04fdf2f > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeederUtil.java > 15dd5c9 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java > 43d908e > ambari-logsearch/ambari-logsearch-logfeeder/src/main/scripts/run.sh dba85fa > ambari-logsearch/ambari-logsearch-portal/src/main/scripts/run.sh ca587d5 > ambari-logsearch/docker/.gitignore PRE-CREATION > ambari-logsearch/docker/Dockerfile PRE-CREATION > ambari-logsearch/docker/bin/start.sh PRE-CREATION > ambari-logsearch/docker/logsearch-docker.sh PRE-CREATION > ambari-logsearch/docker/test-config/logfeeder/log4j.xml PRE-CREATION > ambari-logsearch/docker/test-config/logfeeder/logfeeder-env.sh PRE-CREATION > ambari-logsearch/docker/test-config/logfeeder/logfeeder.properties > PRE-CREATION > > ambari-logsearch/docker/test-config/logfeeder/shipper-conf/global.config.json > PRE-CREATION > > ambari-logsearch/docker/test-config/logfeeder/shipper-conf/input.config-hst.json > PRE-CREATION > > ambari-logsearch/docker/test-config/logfeeder/shipper-conf/input.config-logsearch.json > PRE-CREATION > > ambari-logsearch/docker/test-config/logfeeder/shipper-conf/input.config-zookeeper.json > PRE-CREATION > > ambari-logsearch/docker/test-config/logfeeder/shipper-conf/output.config.json > PRE-CREATION > ambari-logsearch/docker/test-config/logsearch/log4j.xml PRE-CREATION > ambari-logsearch/docker/test-config/logsearch/logsearch-env.sh PRE-CREATION > ambari-logsearch/docker/test-config/logsearch/logsearch.properties > PRE-CREATION > ambari-logsearch/docker/test-config/solr/log4j.properties PRE-CREATION > ambari-logsearch/docker/test-config/solr/solr-env.sh PRE-CREATION > ambari-logsearch/docker/test-config/solr/solr.xml PRE-CREATION > ambari-logsearch/docker/test-config/solr/zoo.cfg PRE-CREATION > ambari-logsearch/docker/test-logs/logsearch/logsearch-test-log.json > PRE-CREATION > ambari-logsearch/docker/test-logs/smartsense/hst-agent-test-log.txt > PRE-CREATION > ambari-logsearch/docker/test-logs/zookeeper/zookeeper-test-log.txt > PRE-CREATION > ambari-logsearch/pom.xml 81da0f2 > > Diff: https://reviews.apache.org/r/50069/diff/ > > > Testing > ------- > > From Apache jenkins: > ++1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12818065/AMBARI-17723.patch > against trunk revision . > +1 @author. The patch does not contain any @author tags. > +1 tests included. The patch appears to include 16 new or modified test files. > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > +1 core tests. The patch passed unit tests in > ambari-logsearch/ambari-logsearch-logfeeder > ambari-logsearch/ambari-logsearch-portal. > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/7855//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/7855//console > This message is automatically generated. > > > Thanks, > > Oliver Szabo > >
