> On July 18, 2016, 6:58 a.m., Robert Levas wrote:
> > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json, 
> > line 18
> > <https://reviews.apache.org/r/50047/diff/1/?file=1444192#file1444192line18>
> >
> >     This is redundant...
> >     
> >     `kafka-broker/listeners` = `kafka-broker/listeners`
> 
> Anita Jebaraj wrote:
>     Hi Robert, I had to include the declaration for listeners in 
> kerberos.json since the value for listeners wont be displayed in the UI under 
> the kerberos configuration otherwise. There is a change in value for protocol 
> for listeners in specific cases (if the user hasn't added a listener with 
> PLAINTEXTSASL protocol) and I thought it would be appropriate to include it 
> in kerberos.json, even though the handling is done in the stack-advisor.py

In this case, maybe it is better to do

```
"listeners": ""
```

Else you may wind up with `kafka-broker/listeners` being set to 
`${kafka-broker/listeners}` (literally).


- Robert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50047/#review142546
-----------------------------------------------------------


On July 14, 2016, 5:08 p.m., Anita Jebaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50047/
> -----------------------------------------------------------
> 
> (Updated July 14, 2016, 5:08 p.m.)
> 
> 
> Review request for Ambari, Di Li and Robert Levas.
> 
> 
> Bugs: AMBARI-17694
>     https://issues.apache.org/jira/browse/AMBARI-17694
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When kerberos is enabled, the protocol for listeners in 
> /etc/kafka/conf/server.properties is updated from PLAINTEXT to PLAINTEXTSASL, 
> even though the Ambari UI shows otherwise
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py
>  33275f9 
>   ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json 
> 2b1c01b 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 2a2a3a3 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> a6baeea 
> 
> Diff: https://reviews.apache.org/r/50047/diff/
> 
> 
> Testing
> -------
> 
> Added 1 new test case,
>  Ran mvn test
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Reply via email to