> On July 19, 2016, 2:50 p.m., Lav Jain wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py,
> >  line 392
> > <https://reviews.apache.org/r/50198/diff/2/?file=1447495#file1447495line392>
> >
> >     Should config-name be set to hawq_rm_memory_limit_perseg?

In YARN mode, hawq_rm_memory_limit_perseg is invisible. 
We would like to show the users the error that the memory is low regardless of 
which mode it is on. Hence we show the error on hawq_global_rm_type property, 
which is always visible.


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50198/#review142847
-----------------------------------------------------------


On July 19, 2016, 4:34 p.m., Matt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50198/
> -----------------------------------------------------------
> 
> (Updated July 19, 2016, 4:34 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov and Lav Jain.
> 
> 
> Bugs: AMBARI-17720
>     https://issues.apache.org/jira/browse/AMBARI-17720
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When a user is running on vagrant or single node with low system memory, 
> configurations are not sufficient to allocate containers for "default" 6 
> vsegs per node especially during HASH dist table query or external table 
> query.
> 
> Stack advisor should adjust the config values to ensure service checks and 
> queries (including Random tables, HASH dist tables, PXF ext tables) do not 
> fail.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
>  0bddb07 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  dffe57d 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> 4089b75 
>   ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py 
> f8a9468 
>   ambari-server/src/test/python/common-services/PXF/test_service_advisor.py 
> 7510e5f 
> 
> Diff: https://reviews.apache.org/r/50198/diff/
> 
> 
> Testing
> -------
> 
> Tested on Live cluster
> 
> Added unit tests:
> ```
> test_hawq_master_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_segment_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_standby_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_exception_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No 
> handlers could be found for logger "ambari_alerts"
> ok
> test_missing_configs 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_slave_file 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_successful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_empty_db_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status_plural 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... 
> ok
> test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
> test_install_default (test_hawqmaster.TestHawqMaster) ... ok
> test_remove_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Remove HAWQ Standby ... 2016-07-19 12:12:33,657 - Removing 
> HAWQ Standby Master ...
> ok
> test_resync_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Resync HAWQ Standby ... 2016-07-19 12:12:33,660 - HAWQ 
> Standby Master Re-Sync started in fast mode...
> ok
> test_run_hawq_check_case1 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 1: Non HDFS-HA, Standalone Resource Management, Not 
> Kerberized ... 2016-07-19 12:12:33,663 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case10 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 10: HDFS-HA, YARN Resource Management Non YARN_HA, 
> Kerberized ... 2016-07-19 12:12:33,669 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case11 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 11: HDFS-HA, YARN Resource Management YARN_HA, Not 
> Kerberized ... 2016-07-19 12:12:33,674 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case12 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 12: HDFS-HA, YARN Resource Management YARN_HA, 
> Kerberized ... 2016-07-19 12:12:33,680 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case2 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 2: Non HDFS-HA, Standalone Resource Management, 
> Kerberized ... 2016-07-19 12:12:33,686 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case3 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 3: Non HDFS-HA, YARN Resource Management Non YARN_HA, 
> Not Kerberized ... 2016-07-19 12:12:33,693 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case4 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 4: Non HDFS-HA, YARN Resource Management Non YARN_HA, 
> Kerberized ... 2016-07-19 12:12:33,698 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case5 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 5: Non HDFS-HA, YARN Resource Management YARN_HA, Not 
> Kerberized ... 2016-07-19 12:12:33,704 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case6 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 6: Non HDFS-HA, YARN Resource Management YARN_HA, 
> Kerberized ... 2016-07-19 12:12:33,709 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case7 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 7: HDFS-HA, Standalone Resource Management, Not 
> Kerberized ... 2016-07-19 12:12:33,715 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case8 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 8: HDFS-HA, Standalone Resource Management, 
> Kerberized ... 2016-07-19 12:12:33,722 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case9 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 9: HDFS-HA, YARN Resource Management Non YARN_HA, Not 
> Kerberized ... 2016-07-19 12:12:33,727 - Executing HAWQ Check ...
> ok
> test_start_default (test_hawqmaster.TestHawqMaster) ... 2016-07-19 
> 12:12:33,735 - Skipping ssh key exchange with HAWQ hosts as hawq_ssh_exkeys 
> is either set to false or is not available in hawq-env.xml
> ok
> test_stop_cluster_immediate (test_hawqmaster.TestHawqMaster)
> Run Stop HAWQ Cluster Immediate Mode ... ok
> test_stop_default (test_hawqmaster.TestHawqMaster)
> Run Stop HAWQMASTER ... ok
> test_configure_default (test_hawqsegment.TestHawqSegment) ... ok
> test_install_default (test_hawqsegment.TestHawqSegment) ... ok
> test_start_default (test_hawqsegment.TestHawqSegment) ... ok
> test_stop_default (test_hawqsegment.TestHawqSegment) ... ok
> test_activate_hawq_standby (test_hawqstandby.TestHawqStandby)
> Test Activate HAWQ Standby Command ... 2016-07-19 12:12:33,764 - Activating 
> HAWQ standby...
> ok
> test_configure_default (test_hawqstandby.TestHawqStandby) ... ok
> test_install_default (test_hawqstandby.TestHawqStandby) ... ok
> test_start_default (test_hawqstandby.TestHawqStandby) ... ok
> test_stop_default (test_hawqstandby.TestHawqStandby) ... ok
> test_createComponentLayoutRecommendations_hawq_1_Host 
> (test_service_advisor.TestHAWQ200ServiceAdvisor) ... ok
> test_createComponentLayoutRecommendations_hawq_3_Hosts 
> (test_service_advisor.TestHAWQ200ServiceAdvisor)
> Test that HAWQSTANDBY is recommended on a 3-node cluster ... ok
> test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_already_installed
>  (test_service_advisor.TestHAWQ200ServiceAdvisor)
> Test that HAWQSEGMENT does not get recommended during Add Service Wizard, 
> when HAWQ has already been installed ... ok
> test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_to_be_installed
>  (test_service_advisor.TestHAWQ200ServiceAdvisor)
> Test that HAWQSEGMENT gets recommended correctly during Add Service Wizard, 
> when HAWQ is selected for installation ... ok
> test_createComponentLayoutRecommendations_hawqsegment_cluster_install 
> (test_service_advisor.TestHAWQ200ServiceAdvisor)
> Test that HAWQSEGMENT gets recommended correctly during Cluster Install 
> Wizard, when HAWQ is selected for installation ... ok
> test_createComponentLayoutRecommendations_no_hawq_3_Hosts 
> (test_service_advisor.TestHAWQ200ServiceAdvisor)
> Test no failures when there are no HAWQ components ... ok
> test_getComponentLayoutValidations_hawq_3_Hosts 
> (test_service_advisor.TestHAWQ200ServiceAdvisor)
> Test layout validations for HAWQ components on a 3-node cluster ... ok
> test_getComponentLayoutValidations_hawqsegment_not_co_located_with_datanode 
> (test_service_advisor.TestHAWQ200ServiceAdvisor)
> Test validation warning for HAWQ segment not colocated with DATANODE ... ok
> test_getComponentLayoutValidations_nohawq_3_Hosts 
> (test_service_advisor.TestHAWQ200ServiceAdvisor)
> Test no failures when there are no HAWQ components on a 3-node cluster ... ok
> test_getHostsForMasterComponent 
> (test_service_advisor.TestHAWQ200ServiceAdvisor) ... ok
> test_getServiceConfigurationRecommendations 
> (test_service_advisor.TestHAWQ200ServiceAdvisor) ... ok
> test_recommendHAWQConfigurations 
> (test_service_advisor.TestHAWQ200ServiceAdvisor) ... ok
> test_validateHAWQHdfsClientConfigurations 
> (test_service_advisor.TestHAWQ200ServiceAdvisor) ... ok
> test_validateHAWQSiteConfigurations 
> (test_service_advisor.TestHAWQ200ServiceAdvisor) ... ok
> test_generate_hawq_process_status_cmd (test_utils.TestUtils) ... ok
> 
> ----------------------------------------------------------------------
> Ran 65 tests in 0.212s
> 
> OK
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> 
> ```
> 
> 
> Thanks,
> 
> Matt
> 
>

Reply via email to