-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50233/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and 
Myroslav Papirkovskyy.


Bugs: AMBARI-17809
    https://issues.apache.org/jira/browse/AMBARI-17809


Repository: ambari


Description
-------

dtnode_heapsize should end with "m" like

          "dtnode_heapsize" : "1024m",

but in the cluster it's 

          "dtnode_heapsize" : "1024",


stack_advisor failed with :

20 Jul 2016 04:52:17,900  INFO [pool-17-thread-1] StackAdvisorRunner:71 -     
advisor script stderr: Traceback (most recent call last):
  File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 158, 
in <module>
    main(sys.argv)
  File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 109, 
in main
    result = stackAdvisor.recommendConfigurations(services, hosts)
  File "/var/lib/ambari-server/resources/scripts/../stacks/stack_advisor.py", 
line 760, in recommendConfigurations
    calculation(configurations, clusterSummary, services, hosts)
  File 
"/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.5/services/stack_advisor.py",
 line 46, in recommendOozieConfigurations
    newAdminUsers = "{0},oozie-admin,{1}".format(oozieUser, falconUser)
UnboundLocalError: local variable 'falconUser' referenced before assignment
20 Jul 2016 04:52:17,902 ERROR [pool-17-thread-1] 
ClusterConfigurationRequest:156 - An exception occurred while doing 
configuration topology update: 
org.apache.ambari.server.controller.internal.ConfigurationTopologyException: 
Configuration recommendation failed.

and 1024m hasn't been recommended for dtnode_heapsize


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
b8f3074 
  ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py ca49d9b 

Diff: https://reviews.apache.org/r/50233/diff/


Testing
-------

Unit tests passed


Thanks,

Dmytro Sen

Reply via email to