> On June 3, 2016, 11:20 a.m., Jonathan Hurley wrote:
> > Ship It!
> 
> Jonathan Hurley wrote:
>     Ping. This review is about ~ 3 weeks old. Was it committed? Can we close 
> it out?
> 
> Dmytro Sen wrote:
>     It has been moved out of 2.4.0.

But has this been committed to trunk? If so, the review should be closed.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47730/#review136067
-----------------------------------------------------------


On June 3, 2016, 11:15 a.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47730/
> -----------------------------------------------------------
> 
> (Updated June 3, 2016, 11:15 a.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, Myroslav 
> Papirkovskyy, and Sid Wagle.
> 
> 
> Bugs: AMBARI-16821
>     https://issues.apache.org/jira/browse/AMBARI-16821
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The TimelineMetricsCache implementation in the metrics sink side is currently 
> a ConcurrentSkipListMap. It is better to use pre built cache libraries like 
> Guava that offer more support.
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-common/pom.xml 41ba62e 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/cache/TimelineMetricsCache.java
>  0bed7d0 
>   
> ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/cache/TimelineMetricsCacheTest.java
>  18d973c 
>   
> ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java
>  ea7f72d 
>   ambari-project/pom.xml 2fbb1e1 
>   ambari-server/pom.xml 20d3fab 
> 
> Diff: https://reviews.apache.org/r/47730/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Reply via email to