-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50063/#review142967
-----------------------------------------------------------


Ship it!




Ship It!

- Aravindan Vijayan


On July 15, 2016, 4:56 a.m., Jungtaek Lim wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50063/
> -----------------------------------------------------------
> 
> (Updated July 15, 2016, 4:56 a.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sriharsha Chintalapani, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-17725
>     https://issues.apache.org/jira/browse/AMBARI-17725
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Since Ambari 2.4.0 we have two kinds of Storm metrics into AMS which one is 
> cluster level and another one is topology level.
> Currently we don't add prefix on them which makes them hard to distinguish, 
> which should be needed to create topology level dashboard in Grafana.
> 
> To resolve this we should add the prefix to Storm topology level metrics.
> 
> This patch adds 'topology.' as prefix of topology level metrics so that it 
> can be distinguished.
> 
> Also shows warning message to user (in Storm worker) to notice period ('.') 
> in topology name is not recommended for AMS.
> 
> 
> Diffs
> -----
> 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  9e6cc98 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  271c11f 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  dcc3192 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  c76197b 
> 
> Diff: https://reviews.apache.org/r/50063/diff/
> 
> 
> Testing
> -------
> 
> Build OK via `mvn clean install` for both of storm-sink and storm-sink-legacy.
> Tested manually.
> 
> 
> Thanks,
> 
> Jungtaek Lim
> 
>

Reply via email to