-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48971/#review142981
-----------------------------------------------------------


Ship it!




Ship It!

- Aravindan Vijayan


On July 20, 2016, 4:36 p.m., Masahiro Tanaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48971/
> -----------------------------------------------------------
> 
> (Updated July 20, 2016, 4:36 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Aravindan Vijayan, Gautam Borad, 
> Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-17291
>     https://issues.apache.org/jira/browse/AMBARI-17291
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When installed Storm and Ambari Metrics, `zookeeper.quorum` in 
> /etc/storm/conf/storm-metrics2.properties is looks like this.
> 
> ```
> zookeeper.quorum=[:2181,':2181,c:2181,7:2181,2:2181,0:2181,1:2181,.:2181,a:2181,m:2181,b:2181,a:2181,r:2181,i:2181,.:2181,a:2181,p:2181,a:2181,c:2181,h:2181,e:2181,.:2181,o:2181,r:2181,g:2181,':2181,,:2181,':2181,c:2181,7:2181,2:2181,0:2181,2:2181,.:2181,a:2181,m:2181,b:2181,a:2181,r:2181,i:2181,.:2181,a:2181,p:2181,a:2181,c:2181,h:2181,e:2181,.:2181,o:2181,r:2181,g:2181,':2181,,:2181,':2181,c:2181,7:2181,2:2181,0:2181,3:2181,.:2181,a:2181,m:2181,b:2181,a:2181,r:2181,i:2181,.:2181,a:2181,p:2181,a:2181,c:2181,h:2181,e:2181,.:2181,o:2181,r:2181,g:2181,':2181,]:2181
> ```
> 
> storm.zookeeper.servers is 
> `'c7201.ambari.apache.org','c7202.ambari.apache.org','c7203.ambari.apache.org']`
> 
> Steps to reproduce.
> 
> 1. Install Ambari Server (I used 
> `http://s3.amazonaws.com/dev.hortonworks.com/ambari/centos7/2.x/latest/trunk/ambaribn.repo`)
> 2. Setup and start Ambari Server (`ambari-server setup -s` and `ambari-server 
> start`)
> 3. Install Storm and ZooKeeper via Ambari Server (HDP2.4)
> 4. Install Ambari Metrics
> 5. Restart all required
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  fac6331 
> 
> Diff: https://reviews.apache.org/r/48971/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test && manual test 
> ```
> --1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12811836/AMBARI-17291.1.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> -1 core tests. The test build failed in ambari-server
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7426//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7426//console
> This message is automatically generated.
> ```
> 
> Core test fails seems unrelated to this patch
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Reply via email to