-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50302/#review143096
-----------------------------------------------------------




ambari-agent/src/main/python/ambari_agent/ActionQueue.py 
<https://reviews.apache.org/r/50302/#comment208809>

    Removed since they were never set in Java



ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
 (line 526)
<https://reviews.apache.org/r/50302/#comment208810>

    When simply checking the command type, there's no need to fully deserialize 
the execution command.



ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java
 (lines 115 - 125)
<https://reviews.apache.org/r/50302/#comment208811>

    Biggest change was here; basically if refresh configs is set, then do that 
first. This way, it allows an empty set of tags to be passed in. Upgrades takes 
advantage of this by not having to lookup the config tags 1000's of times ahead 
of time.



ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
 (lines 91 - 92)
<https://reviews.apache.org/r/50302/#comment208812>

    It made no sense to break this out by config type. I can't imagine a reason 
for needing to only update 1 config out of 30 - just get them all. 
    
    Also, it wasn't being used and was overly complicated.



ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 
<https://reviews.apache.org/r/50302/#comment208813>

    This property was never used and was confusing, so we removed it.


- Jonathan Hurley


On July 21, 2016, 12:39 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50302/
> -----------------------------------------------------------
> 
> (Updated July 21, 2016, 12:39 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Nate 
> Cole, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17836
>     https://issues.apache.org/jira/browse/AMBARI-17836
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> During Mission Control testing, it was clear that we were making 1000's of 
> database calls during the creation of the orchestration for upgrades. These 
> mostly revolved around getting configuration tags which was silly since we 
> were always refreshing them before executing the command. 
> 
> I decided that if you're specifying that the config tags shoudl be refreshed, 
> then there's no need to do any of the work ahead of time to fetch them. This 
> significantly reduced the number of hot methods during the orchestration of 
> an upgrade.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py 1e7b1b6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
>  205ef9f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java
>  ef12c3a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  28de8ed 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  399f26c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
>  9c2db1c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  2174a64 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  c390f44 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
>  7a5f377 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java
>  115b518 
> 
> Diff: https://reviews.apache.org/r/50302/diff/
> 
> 
> Testing
> -------
> 
> PENDING
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Reply via email to