-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50302/#review143098
-----------------------------------------------------------


Ship it!




Ship It!

- Nate Cole


On July 21, 2016, 12:39 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50302/
> -----------------------------------------------------------
> 
> (Updated July 21, 2016, 12:39 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Nate 
> Cole, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17836
>     https://issues.apache.org/jira/browse/AMBARI-17836
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> During Mission Control testing, it was clear that we were making 1000's of 
> database calls during the creation of the orchestration for upgrades. These 
> mostly revolved around getting configuration tags which was silly since we 
> were always refreshing them before executing the command. 
> 
> I decided that if you're specifying that the config tags shoudl be refreshed, 
> then there's no need to do any of the work ahead of time to fetch them. This 
> significantly reduced the number of hot methods during the orchestration of 
> an upgrade.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py 1e7b1b6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
>  205ef9f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java
>  ef12c3a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  28de8ed 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  399f26c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
>  9c2db1c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  2174a64 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  c390f44 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
>  7a5f377 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java
>  115b518 
> 
> Diff: https://reviews.apache.org/r/50302/diff/
> 
> 
> Testing
> -------
> 
> PENDING
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Reply via email to