-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50349/#review143243
-----------------------------------------------------------


Fix it, then Ship it!




Ship It!


ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
(lines 88 - 90)
<https://reviews.apache.org/r/50349/#comment209023>

    You should use `stacks.stack_advisor.DefaultStackAdvisor#isSecurityEnabled`.


- Robert Levas


On July 22, 2016, 12:53 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50349/
> -----------------------------------------------------------
> 
> (Updated July 22, 2016, 12:53 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Robert Levas.
> 
> 
> Bugs: AMBARI-17859
>     https://issues.apache.org/jira/browse/AMBARI-17859
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> *Steps*
> # Deploy HDP-2.4.0.0 cluster with Ambari 2.2.1.1 (secure, non-HA cluster, 
> customized service users)
> # Upgrade Ambari to 2.4.0.0
> # Perform EU to 2.5.0.0-934
> 
> There is not live cluster to see what happened. We had a similar issue 
> previously, when core-site was not provided by UI (e.g. when deleting 
> services) because Atlas had not dependencies on it. Similar issue was 
> addressed by AMBARI-17536 (The FE should always send the cluster-env config 
> when invoking the Recommendations REST API), so changing logic to depend on 
> cluster-env instead of core-site at least should not harm. 
> 
> ```
> Traceback (most recent call last):\n  File 
> \"/var/lib/ambari-agent/cache/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py\",
>  line 159, in <module>\n    ServiceCheck().execute()\n  File 
> \"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py\",
>  line 280, in execute\n    method(env)\n  File 
> \"/var/lib/ambari-agent/cache/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py\",
>  line 117, in service_check\n    user=params.smokeuser,\n  File 
> \"/usr/lib/python2.6/site-packages/resource_management/core/shell.py\", line 
> 71, in inner\n    result = function(command, **kwargs)\n  File 
> \"/usr/lib/python2.6/site-packages/resource_management/core/shell.py\", line 
> 93, in checked_call\n    tries=tries, try_sleep=try_sleep)\n  File 
> \"/usr/lib/python2.6/site-packages/resource_management/core/shell.py\", line 
> 141, in _call_wrapper\n    result = _call(command, **kwargs_copy)\n  File 
> \"/usr/lib/python2.6/site-packages/resource_management/core/shell.py\"
 , line 294, in _call\n    raise 
Fail(err_msg)\nresource_management.core.exceptions.Fail: Execution of 
'/usr/bin/kinit -kt /etc/security/keytabs/smokeuser.headless.keytab 
smk_rndalxit7oqf2pq3erlqg6r...@hwqe.hortonworks.com; yarn 
org.apache.hadoop.yarn.applications.distributedshell.Client -shell_command ls 
-num_containers 1 -jar 
/usr/hdp/current/hadoop-yarn-client/hadoop-yarn-applications-distributedshell.jar
 -timeout 300000 --queue default' returned 2. ######## Hortonworks 
#############\nThis is MOTD message, added for testing in qe infra\n16/07/09 
11:15:01 INFO impl.TimelineClientImpl: Timeline service address: 
http://host:8188/ws/v1/timeline/\n16/07/09 11:15:01 INFO 
distributedshell.Client: Initializing Client\n16/07/09 11:15:01 INFO 
distributedshell.Client: Running Client\n16/07/09 11:15:01 INFO client.RMProxy: 
Connecting to ResourceManager at host-5.domainlocal/10.0.113.157:8050\n16/07/09 
11:15:03 INFO distributedshell.Client: Got Cluster metric info from ASM, 
numNodeManagers=3\n
 16/07/09 11:15:03 INFO distributedshell.Client: Got Cluster node info from 
ASM\n16/07/09 11:15:03 INFO distributedshell.Client: Got node report from ASM 
for, nodeId=host:25454, nodeAddresshost:8042, nodeRackName/default-rack, 
nodeNumContainers0\n16/07/09 11:15:03 INFO distributedshell.Client: Got node 
report from ASM for, nodeId=host-5.domainlocal:25454, 
nodeAddresshost-5.domainlocal:8042, nodeRackName/default-rack, 
nodeNumContainers0\n
> ```
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
> cfbcbbf 
> 
> Diff: https://reviews.apache.org/r/50349/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Reply via email to