----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50354/ -----------------------------------------------------------
Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. Bugs: AMBARI-17863 https://issues.apache.org/jira/browse/AMBARI-17863 Repository: ambari Description ------- Queries to AMS with topN specified do not work if metric name has wildcard (%) in them. Example: collectorhost:port/ws/v1/timeline/metrics?metricNames=cpu_%&appId=HOST&startTime=1469203016&endtime=1469204816&topN=2&isBottomN=false Diffs ----- ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/DefaultCondition.java 81528df ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/TopNCondition.java fae1655 ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestPhoenixTransactSQL.java b4cee67 ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TopNConditionTest.java PRE-CREATION Diff: https://reviews.apache.org/r/50354/diff/ Testing ------- Manually tested. Added unit test. mvn clean test Thanks, Aravindan Vijayan