-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50352/
-----------------------------------------------------------

(Updated July 22, 2016, 8:38 p.m.)


Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-17843
    https://issues.apache.org/jira/browse/AMBARI-17843


Repository: ambari


Description
-------

timeline.metrics.service.cluster.aggregator.appIds defines what apps to produce 
host metrics for:
{quote}List of application ids to use for aggregating host level metrics for
      an application. Example: bytes_read across Yarn Nodemanagers. {quote}

Right now we are aggregating for all.

Additionally, metadata does not expose these additional metrics
{code}
0: jdbc:phoenix:localhost:61181:/ams-hbase-un> select distinct(APP_ID) from 
METRIC_AGGREGATE_MINUTE WHERE METRIC_NAME = 'cpu_user';
+------------+
|   APP_ID   |
+------------+
| HOST       |
| ams-hbase  |
| amssmoketestfake |
| applicationhistoryserver |
| datanode   |
| hivemetastore |
| hiveserver2 |
| jobhistoryserver |
| namenode   |
| nimbus     |
| nodemanager |
| resourcemanager |
+------------+
12 rows selected (0.117 seconds)
{code}


Diffs (updated)
-----

  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricAppAggregator.java
 05beb76 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/discovery/TimelineMetricMetadataKey.java
 ec97ee5 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/discovery/TimelineMetricMetadataManager.java
 9fa2066 

Diff: https://reviews.apache.org/r/50352/diff/


Testing
-------

mvn clean test

Tested manually.


Thanks,

Aravindan Vijayan

Reply via email to