-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50373/#review143316
-----------------------------------------------------------


Ship it!




Good catch.

- Sumit Mohanty


On July 23, 2016, 7:25 a.m., Ajit Kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50373/
> -----------------------------------------------------------
> 
> (Updated July 23, 2016, 7:25 a.m.)
> 
> 
> Review request for Ambari, Andriy Babiichuk, Aleksandr Kovalenko, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-17867
>     https://issues.apache.org/jira/browse/AMBARI-17867
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Fix KERBEROS/1.10.3-10/configuration/kerberos-env.xml which has bad xml 
> element "<type>host</type>" at line number 89. This is breaking build 
> https://builds.apache.org/job/Ambari-trunk-Commit/5372
> Unit test failing:
> org.apache.ambari.server.state.ServicePropertiesTest.validatePropertySchemaOfServiceXMLs
> 
> org.apache.ambari.server.AmbariException: File 
> /Users/ajit.kumar/workspace/ambari/ambari-server/target/test-classes/TestAmbaryServer.samples/../../../src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
>  didn't pass the validation. Error message is : cvc-complex-type.2.4.a: 
> Invalid content was found starting with element 'type'. One of '{maximum, 
> minimum, unit, delete, empty-value-valid, ui-only-property, read-only, 
> editable-only-at-install, show-property-name, increment-step, entries, 
> hidden, entries_editable, selection-cardinality, property-file-name, 
> property-file-type}' is expected.
> 
>       at 
> org.apache.ambari.server.stack.StackManager.validateAllPropertyXmlsInFolderRecursively(StackManager.java:452)
>       at 
> org.apache.ambari.server.state.ServicePropertiesTest.validatePropertySchemaOfServiceXMLs(ServicePropertiesTest.java:48)
>       at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>       at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>       at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>       at java.lang.reflect.Method.invoke(Method.java:497)
>       at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45)
>       at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
>       at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42)
>       at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
>       at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263)
>       at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:68)
>       at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:47)
>       at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
>       at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60)
>       at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229)
>       at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50)
>       at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222)
>       at org.junit.runners.ParentRunner.run(ParentRunner.java:300)
>       at org.junit.runner.JUnitCore.run(JUnitCore.java:157)
>       at 
> com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:119)
>       at 
> com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:42)
>       at 
> com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:234)
>       at 
> com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:74)
>       at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>       at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>       at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>       at java.lang.reflect.Method.invoke(Method.java:497)
>       at com.intellij.rt.execution.application.AppMain.main(AppMain.java:144)
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
>  0e219a4 
> 
> Diff: https://reviews.apache.org/r/50373/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ajit Kumar
> 
>

Reply via email to