> On July 21, 2016, 6:18 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml,
> >  line 379
> > <https://reviews.apache.org/r/50140/diff/3/?file=1449719#file1449719line379>
> >
> >     We havent restarted RANGER on the new version at this point right? So 
> > we are setting alerts beforehand? Shouldnt we do this after RANGER is 
> > upgraded?
> >     
> >     Also what about DOWNGRADE? If we go all the way to Finalize step and 
> > kick DOWNGRADE will old alerts be restored?

@Jayush, the attached patch was tested for both upgrade and downgrade scenarios 
and it worked fine.


- Gautam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50140/#review143116
-----------------------------------------------------------


On July 21, 2016, 12:36 p.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50140/
> -----------------------------------------------------------
> 
> (Updated July 21, 2016, 12:36 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Mahadev 
> Konar, Sumit Mohanty, Selvamohan Neethiraj, Srimanth Gunturi, and Velmurugan 
> Periasamy.
> 
> 
> Bugs: AMBARI-17771
>     https://issues.apache.org/jira/browse/AMBARI-17771
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Update alert definition URI after stack is updated.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigAction.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  7be5a1915c00853b2817b815124752063222d59d 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 7f277fb02cf24e64b16171c2cd13cb94f9518ada 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  2daa9b8907aa8159829b40007ec2ae81ffcdb29c 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 43c6265b00240790ed96aadcaddff5b7b97d4b95 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigActionTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks/HDP/2.5.0/services/RANGER/alerts.json 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50140/diff/
> 
> 
> Testing
> -------
> 
> Tested on a centos 6 cluster after upgrade and checked that the alert works 
> fine for Ranger Admin.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>

Reply via email to