> On July 25, 2016, 6:49 a.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java,
> >  line 1043
> > <https://reviews.apache.org/r/50390/diff/1/?file=1451850#file1451850line1043>
> >
> >     Wouldn't it be better to do:
> >     
> >     ```
> >     if (Role.AMBARI_SERVER_ACTION != hostRoleCommand.getRole())
> >     ```
> 
> Nate Cole wrote:
>     I think actually 
> !Role.AMBARI_SERVER_ACTION.equals(hostRoleCommand.getRole()) as Role isn't 
> actually an Enum.

Interesting.. I always thought it was.  Nice catch.


- Robert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50390/#review143361
-----------------------------------------------------------


On July 25, 2016, 6:03 a.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50390/
> -----------------------------------------------------------
> 
> (Updated July 25, 2016, 6:03 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, Nate 
> Cole, and Robert Levas.
> 
> 
> Bugs: AMBARI-17878
>     https://issues.apache.org/jira/browse/AMBARI-17878
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> *add service operation hangs in Preparing to execute Set Keytab*
> 
> 1. install ambari2.4.0 with stack 2.4
> 2. express upgrade to stack 2.5
> 3. finalize the upgrade
> 4. add new services ( kms,atlas,slider)
> 
> Null pointer exception is thrown in ambari-server logs
> 
> {code}
> 
> 18 Jul 2016 07:12:32,025 ERROR [ambari-metrics-retrieval-service-thread-105] 
> MetricsRetrievalService:421 - Unable to retrieve metrics from 
> http://host:8744/api/v1/cluster/summary. Subsequent failures will be 
> suppressed from the log for 5 minutes.
> java.net.ConnectException: Connection refused
> at java.net.PlainSocketImpl.socketConnect(Native Method)
> at 
> java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:350)
> at 
> java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:206)
> at java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:188)
> at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
> at java.net.Socket.connect(Socket.java:589)
> at sun.net.NetworkClient.doConnect(NetworkClient.java:175)
> at sun.net.www.http.HttpClient.openServer(HttpClient.java:432)
> at sun.net.www.http.HttpClient.openServer(HttpClient.java:527)
> at sun.net.www.http.HttpClient.<init>(HttpClient.java:211)
> at sun.net.www.http.HttpClient.New(HttpClient.java:308)
> at sun.net.www.http.HttpClient.New(HttpClient.java:326)
> at 
> sun.net.www.protocol.http.HttpURLConnection.getNewHttpClient(HttpURLConnection.java:1169)
> at 
> sun.net.www.protocol.http.HttpURLConnection.plainConnect0(HttpURLConnection.java:1105)
> at 
> sun.net.www.protocol.http.HttpURLConnection.plainConnect(HttpURLConnection.java:999)
> at 
> sun.net.www.protocol.http.HttpURLConnection.connect(HttpURLConnection.java:933)
> at 
> sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1513)
> at 
> sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1441)
> at java.net.HttpURLConnection.getResponseCode(HttpURLConnection.java:480)
> at 
> org.apache.ambari.server.controller.internal.URLStreamProvider.processURL(URLStreamProvider.java:218)
> at 
> org.apache.ambari.server.controller.internal.URLStreamProvider.processURL(URLStreamProvider.java:142)
> at 
> org.apache.ambari.server.controller.internal.URLStreamProvider.readFrom(URLStreamProvider.java:116)
> at 
> org.apache.ambari.server.controller.internal.URLStreamProvider.readFrom(URLStreamProvider.java:121)
> at 
> org.apache.ambari.server.state.services.MetricsRetrievalService$MetricRunnable.run(MetricsRetrievalService.java:382)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {code}
> 
> {code}
> 
> 
> 18 Jul 2016 07:42:39,979  WARN [ambari-action-scheduler] ActionScheduler:202 
> - Exception received
> java.lang.NullPointerException
> at java.util.concurrent.ConcurrentHashMap.get(ConcurrentHashMap.java:936)
> at org.apache.ambari.server.agent.ActionQueue.getQueue(ActionQueue.java:52)
> at org.apache.ambari.server.agent.ActionQueue.enqueue(ActionQueue.java:61)
> at 
> org.apache.ambari.server.actionmanager.ActionScheduler.cancelCommandOnTimeout(ActionScheduler.java:1084)
> at 
> org.apache.ambari.server.actionmanager.ActionScheduler.processInProgressStage(ActionScheduler.java:725)
> at 
> org.apache.ambari.server.actionmanager.ActionScheduler.doWork(ActionScheduler.java:290)
> at 
> org.apache.ambari.server.actionmanager.ActionScheduler.run(ActionScheduler.java:197)
> at java.lang.Thread.run(Thread.java:745)
> {code}
> 
> Note: this is an upgraded cluster from hdp-2.4 to hdp-2.5 , addition of the 
> service is done after upgrade.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
>  205ef9f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java
>  0b24765 
> 
> Diff: https://reviews.apache.org/r/50390/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Reply via email to