> On July 25, 2016, 1:42 p.m., Robert Levas wrote:
> > Ship It!

I nit-picked on the wording of the error messages.  Esstually all is good, but 
I think the error messages could have been clearer.  My comment read "may not 
be correct", but I really meant "may not be clear".  That is ironc, being that 
my comment wasn't clear. ;)


- Robert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50396/#review143399
-----------------------------------------------------------


On July 25, 2016, 1:18 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50396/
> -----------------------------------------------------------
> 
> (Updated July 25, 2016, 1:18 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, Robert Levas, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17889
>     https://issues.apache.org/jira/browse/AMBARI-17889
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> While installing a cluster, I forgot to call:
> {{ambari-server setup --jdbc-db=mysql 
> --jdbc-driver=/usr/share/java/mysql-connector-java.jar}}
> 
> Check DB connection failed with:
> {code}
> 2016-07-13 00:56:32,751 - There was an unknown error while checking database 
> connectivity: cannot concatenate 'str' and 'NoneType' objects
> Traceback (most recent call last):
>   File "/var/lib/ambari-agent/cache/custom_actions/scripts/check_host.py", 
> line 144, in actionexecute
>     db_connection_check_structured_output = 
> self.execute_db_connection_check(config, tmp_dir)
>   File "/var/lib/ambari-agent/cache/custom_actions/scripts/check_host.py", 
> line 285, in execute_db_connection_check
>     jdbc_url = jdk_location + jdbc_driver_mysql_name
> TypeError: cannot concatenate 'str' and 'NoneType' objects
> 2016-07-13 00:56:32,752 - Check db_connection_check was unsuccessful. Exit 
> code: 1. Message: cannot concatenate 'str' and 'NoneType' objects
> 
> Traceback (most recent call last):
>   File "/var/lib/ambari-agent/cache/custom_actions/scripts/check_host.py", 
> line 506, in <module>
>     CheckHost().execute()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 280, in execute
>     method(env)
>   File "/var/lib/ambari-agent/cache/custom_actions/scripts/check_host.py", 
> line 206, in actionexecute
>     raise Fail(error_message)
> resource_management.core.exceptions.Fail: Check db_connection_check was 
> unsuccessful. Exit code: 1. Message: cannot concatenate 'str' and 'NoneType' 
> objects
> {code}
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/custom_actions/scripts/check_host.py 
> 3d9dfa8 
> 
> Diff: https://reviews.apache.org/r/50396/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Reply via email to