> On July 25, 2016, 6:09 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py, > > line 161 > > <https://reviews.apache.org/r/50377/diff/1/?file=1451592#file1451592line161> > > > > small nitpick here, can remove outside parentheses.
Well, looks like "()" is used here to avoid having to use line breaks "\". So leaving it unchanged as most of the other security_status() calls follow this pattern. - Sumit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50377/#review143403 ----------------------------------------------------------- On July 24, 2016, 3:31 a.m., Sumit Mohanty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50377/ > ----------------------------------------------------------- > > (Updated July 24, 2016, 3:31 a.m.) > > > Review request for Ambari, Alejandro Fernandez and Robert Levas. > > > Bugs: AMBARI-17869 > https://issues.apache.org/jira/browse/AMBARI-17869 > > > Repository: ambari > > > Description > ------- > > Add support for new properties to detect security status > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py > f18809f > ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py 3797cf3 > > Diff: https://reviews.apache.org/r/50377/diff/ > > > Testing > ------- > > Manually ran UT and tested on a kerberized cluster. UTs pass. > > > Thanks, > > Sumit Mohanty > >
