> On July 26, 2016, 4:36 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/TaskWrapperBuilder.java,
> >  lines 59-61
> > <https://reviews.apache.org/r/50461/diff/1/?file=1454273#file1454273line59>
> >
> >     Won't all CONFIGURE tasks have hosts since they run on the Ambari 
> > Server?

CONFIGURE tasks are indeed run on the server (that's why we use 
Collections.singleton(ambariServerHostname)), but the hostsType object 
represents the component's hosts that the task is defined FOR.  I'm still doing 
some testing around that.


- Nate


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50461/#review143605
-----------------------------------------------------------


On July 26, 2016, 4:17 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50461/
> -----------------------------------------------------------
> 
> (Updated July 26, 2016, 4:17 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-17904
>     https://issues.apache.org/jira/browse/AMBARI-17904
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When creating a Downgrade, the TaskWrapperBuilder is not checking for host 
> components that do NOT require CONFIGURE/MANUAL tasks to be scheduled.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/TaskWrapperBuilder.java
>  f2ef8f0 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java
>  55b44bf 
> 
> Diff: https://reviews.apache.org/r/50461/diff/
> 
> 
> Testing
> -------
> 
> Manual verification.  Added unit test, pending automated results.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Reply via email to