-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50479/
-----------------------------------------------------------

(Updated 7 27, 2016, 2:52 오전)


Review request for Ambari, Aravindan Vijayan, Sriharsha Chintalapani, and Sid 
Wagle.


Changes
-------

Change on-ambari-upgrade values to true


Bugs: AMBARI-17909
    https://issues.apache.org/jira/browse/AMBARI-17909


Repository: ambari


Description
-------

Abstraction:
This issue is for following up changes on STORM-2006: Storm metrics feature 
improvement: support per-worker level metrics aggregation.

Details:
With recent patches for AMS and AMS Storm sink, AMS stores task level metrics 
from Storm, and relevant dashboards can be configured via Grafana.
But we found that it incurs too many kinds of metrics and also too many data 
points published to AMS because even a topology can have lots of tasks.
In order to reduce this, I addressed STORM-2006, but it also needs AMS Storm 
sink and relevant Storm configurations to be changed.

Note:
We're moving some properties so STORM-2006 must be go on together in order to 
make metrics filter working properly. But AMS Storm sink itself is backward 
compatible.
I don't modify legacy AMS Storm sink since STORM-2006 will not be ported back 
to 0.10.x or lower.


Diffs (updated)
-----

  
ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
 3a4289b 
  
ambari-metrics/ambari-metrics-storm-sink/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
 fadb00c 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/storm-site.xml
 280fc42 

Diff: https://reviews.apache.org/r/50479/diff/


Testing
-------

- Build succeed (build passed with 2.4 branch without Ignore annotation)
- Tested manually with STORM-2006 pre-applied cluster


Thanks,

Jungtaek Lim

Reply via email to