-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50539/#review143928
-----------------------------------------------------------




ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java
 (lines 240 - 244)
<https://reviews.apache.org/r/50539/#comment209877>

    I'm a little confused by this - cluster.getConfig() doesn't declare any 
exceptions, so what are you catching?
    
    Also, no other part of this code explicitly throws an AmbariException, so 
should we fail the task or just move past it with a COMPLETED instead?



ambari-server/src/main/resources/stacks/HDP/2.5/services/SQOOP/configuration/sqoop-atlas-application.properties.xml
 (lines 30 - 36)
<https://reviews.apache.org/r/50539/#comment209878>

    Do you need the on-ambari-upgrade tags for this file?  ambari-server tests 
will fail without it if that's the case.


- Nate Cole


On July 27, 2016, 7:06 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50539/
> -----------------------------------------------------------
> 
> (Updated July 27, 2016, 7:06 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, 
> Jonathan Hurley, Nate Cole, Sumit Mohanty, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-17935
>     https://issues.apache.org/jira/browse/AMBARI-17935
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> STR
> 1. Deploy Ambari 2.2.2 with HDP 2.4 and Sqoop
> 2. Kerberize the cluster
> 3. Upgrade Ambari to 2.4.0
> 4. Install bits for HDP 2.5 and attempt to perform Express Upgrade
> 
> Observed error during Express Upgrade
> ```
> Failed on: Updating configuration sqoop-atlas-application.properties
> 
> Server action failed
> ```
> 
> This happens because the sqoop-atlas-application.properties config in HDP 2.5 
> hasn't been created yet since it doesn't actually have any configs. To fix 
> it, add some configs so the merging process creates the new config type.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java
>  f7de8a9 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  133db26 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  d648638 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SQOOP/configuration/sqoop-atlas-application.properties.xml
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50539/diff/
> 
> 
> Testing
> -------
> 
> Verified during EU from HDP 2.4 to 2.5 with Sqoop.
> 
> Python unit tests passed,
> 
> ----------------------------------------------------------------------
> Total run:1034
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Reply via email to