----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50567/#review143930 -----------------------------------------------------------
Ship it! Ship It! - Nate Cole On July 28, 2016, 9:18 a.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50567/ > ----------------------------------------------------------- > > (Updated July 28, 2016, 9:18 a.m.) > > > Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole. > > > Bugs: AMBARI-17946 > https://issues.apache.org/jira/browse/AMBARI-17946 > > > Repository: ambari > > > Description > ------- > > Intermittently, the pre-stack upgrade checks will fail with a > {{ConcurrentModificationException}}: > > {code} > WARNING: A HTTP GET method, public javax.ws.rs.core.Response > org.apache.ambari.server.api.services.PreUpgradeCheckService.getPreUpgradeChecks(java.lang.String,javax.ws.rs.core.HttpHeaders,javax.ws.rs.core.UriInfo), > should not consume any entity. > 27 Jul 2016 04:21:27,035 ERROR [ambari-client-thread-35] CheckHelper:120 - > Check HOSTS_MASTER_MAINTENANCE failed > java.util.ConcurrentModificationException > at > java.util.LinkedHashMap$LinkedHashIterator.nextNode(LinkedHashMap.java:711) > at > java.util.LinkedHashMap$LinkedValueIterator.next(LinkedHashMap.java:739) > at > org.apache.ambari.server.checks.HostsMasterMaintenanceCheck.perform(HostsMasterMaintenanceCheck.java:83) > at > org.apache.ambari.server.state.CheckHelper.performChecks(CheckHelper.java:99) > at > org.apache.ambari.server.controller.internal.PreUpgradeCheckResourceProvider.getResources(PreUpgradeCheckResourceProvider.java:192) > at > org.apache.ambari.server.controller.internal.ClusterControllerImpl$ExtendedResourceProviderWrapper.queryForResources(ClusterControllerImpl.java:966) > at > org.apache.ambari.server.controller.internal.ClusterControllerImpl.getResources(ClusterControllerImpl.java:141) > {code} > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/PreUpgradeCheckService.java > 0525b3a > > ambari-server/src/main/java/org/apache/ambari/server/api/services/UpgradeService.java > 8b66491 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java > 486d432 > > ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerTest.java > ee0a951 > > Diff: https://reviews.apache.org/r/50567/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Jonathan Hurley > >
