> On July 29, 2016, 10:54 a.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py, line 
> > 1132
> > <https://reviews.apache.org/r/50595/diff/1/?file=1457506#file1457506line1132>
> >
> >     What happens if the version changes?

The version cannot change as that is the only version we can support - but I 
don't think this symlink is even needed - so can drop it


> On July 29, 2016, 10:54 a.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py, line 
> > 1143
> > <https://reviews.apache.org/r/50595/diff/1/?file=1457506#file1457506line1143>
> >
> >     Why is there a version number in this jar name?

Will remove 5.0* but the only version we support is that.


> On July 29, 2016, 10:54 a.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py,
> >  line 203
> > <https://reviews.apache.org/r/50595/diff/1/?file=1457507#file1457507line203>
> >
> >     If there are any exceptions, please log it.

Since we log exceptions in DonwloadSource did not do it.   But it does not hurt 
to add it here also.  will add


> On July 29, 2016, 10:54 a.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py,
> >  line 211
> > <https://reviews.apache.org/r/50595/diff/1/?file=1457507#file1457507line211>
> >
> >     Typo.

will fix.  thanks


- Venkat


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50595/#review144139
-----------------------------------------------------------


On July 29, 2016, 11:56 a.m., Venkat Ranganathan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50595/
> -----------------------------------------------------------
> 
> (Updated July 29, 2016, 11:56 a.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-17955
>     https://issues.apache.org/jira/browse/AMBARI-17955
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Enabled the registration of optionally downloaded berkeley db jar file.   
> Introduce Berekley DB as a jdbc-db (even though it is actually not.   
> Download je-5.0.73.jar if not already present and inform users on how to 
> register
> 
> also, fixed Atlas integration changes with classname and packagename
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/python/ambari_server/dbConfiguration.py fc68a4c 
>   ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py 
> d09bd77 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  dd1cda0 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  ebe3634 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 8d5cdc9 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> f8ba3e9 
> 
> Diff: https://reviews.apache.org/r/50595/diff/
> 
> 
> Testing
> -------
> 
> Tested downloading of the jar file by registering with ambari server
> Tested Falcon/Atlas component names
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Reply via email to