-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50297/#review144332
-----------------------------------------------------------


Ship it!




Ship It!

- Oliver Szabo


On Aug. 1, 2016, 1:10 p.m., Hemanth Yamijala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50297/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2016, 1:10 p.m.)
> 
> 
> Review request for Ambari, Hayat Behlim, Dharmesh Makwana, Miklos Gergely, 
> and Oliver Szabo.
> 
> 
> Bugs: AMBARI-17788
>     https://issues.apache.org/jira/browse/AMBARI-17788
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This patch extracts spooling functions outside OutputHDFSFile so that it can 
> be used for AMBARI-17785. The patch allows callbacks to check the condition 
> on which spool files should be rolled over and what to do on rollover.
> 
> 
> Diffs
> -----
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputHDFSFile.java
>  87cc0eb 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/LogSpooler.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/LogSpoolerContext.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/LogSpoolerException.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/RolloverCondition.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/RolloverHandler.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/spool/LogSpoolerTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50297/diff/
> 
> 
> Testing
> -------
> 
> * New unit tests.
> * Have tested by installing new RPM on an existing Ambari installation and 
> configuring the output for one of the services to write to HDFS. Tested that 
> upload to HDFS, rollover is working correctly for this service.
> 
> 
> Thanks,
> 
> Hemanth Yamijala
> 
>

Reply via email to