-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50646/#review144353
-----------------------------------------------------------


Ship it!




Ship It!

- Swapan Shridhar


On Aug. 1, 2016, 12:09 a.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50646/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2016, 12:09 a.m.)
> 
> 
> Review request for Ambari, Di Li, Jonathan Hurley, Jayush Luniya, Nate Cole, 
> Robert Levas, Swapan Shridhar, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-17972
>     https://issues.apache.org/jira/browse/AMBARI-17972
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> AMBARI-17782 made changes so that HDP 2.5 with Sqoop in a kerberized cluster 
> would set configs in sqoop-atlas-application.properties:
> atlas.jaas.KafkaClient.option.useTicketCache=true
> atlas.jaas.KafkaClient.option.renewTicket=true
> 
> However, the kerberos.json file that was added broke some tests and had to be 
> reverted because it didn't contain any identities or components. Now, readd 
> the file and add some unit tests so that a kerberos.json file without any 
> components is supported.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  16266cf 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SQOOP/kerberos.json 
> PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
>  6387fe8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptorTest.java
>  033a0e2 
> 
> Diff: https://reviews.apache.org/r/50646/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed.
> 
> KerberosHelperTest.java
> KerberosServiceDescriptorTest.java
> 
> 
> Python unit tests,
> Total run:1034
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Reply via email to