----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50645/#review144480 -----------------------------------------------------------
ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/kafka-broker.xml (line 169) <https://reviews.apache.org/r/50645/#comment210496> If this is deleted, is there any other way to get the port Since this is marked as dependent on atlas.kafka.bootstrap.servers/tagsync-application-properties.xml Link: https://github.com/apache/ambari/blob/branch-2.4/ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/tagsync-application-properties.xml#L30-L45 ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-audit.xml (line 21) <https://reviews.apache.org/r/50645/#comment210497> This config file is a part of RANGER KMS service and doesn't require changes. - Mugdha Varadkar On Aug. 2, 2016, 12:20 a.m., Sumit Mohanty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50645/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2016, 12:20 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Jaimin > Jetly, and Mugdha Varadkar. > > > Bugs: AMBARI-17971 > https://issues.apache.org/jira/browse/AMBARI-17971 > > > Repository: ambari > > > Description > ------- > > Ambari upgrade to 2.4.0 adds several config properties that are not necessary > and some are incorrect. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml > 108c7b4 > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/atlas-log4j.xml > a071442 > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/atlas-solrconfig.xml > 35e9f58 > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py > 1a0e797 > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py > 8006158 > > ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/configuration/atlas-solrconfig.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-atlas-application.properties.xml > e653651 > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/kafka-broker.xml > 0275358 > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-audit.xml > 5257549 > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-plugin-properties.xml > 74cdf63 > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-policymgr-ssl.xml > f0fc160 > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-security.xml > 3967e3e > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ranger-knox-plugin-properties.xml > f0f6f41 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-audit.xml > 50a997c > > ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/configuration/sqoop-site.xml > f7823d2 > > ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-audit.xml > b7cf4c5 > > ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-policymgr-ssl.xml > 9592914 > > ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-security.xml > 5f0e944 > > ambari-server/src/main/resources/common-services/STORM/0.9.1/configuration/storm-site.xml > ab7d9cb > > ambari-server/src/main/resources/common-services/STORM/0.9.3/configuration/ranger-storm-plugin-properties.xml > 9ba58b5 > > ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/configuration/hbase-env.xml > 7b55225 > > ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/configuration/hbase-site.xml > 3f860e0 > > ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/configuration/ranger-hbase-plugin-properties.xml > adcf116 > > ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/ranger-hdfs-plugin-properties.xml > 1e65763 > > ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/ranger-hive-plugin-properties.xml > d82c8b4 > > ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/configuration/ranger-knox-plugin-properties.xml > ad2b1e4 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/ranger-hbase-audit.xml > f670d7e > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/ranger-hbase-policymgr-ssl.xml > 79370bc > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/ranger-hbase-security.xml > 7ef63d8 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/ranger-hdfs-audit.xml > 63154eb > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/ranger-hdfs-policymgr-ssl.xml > e14a9e8 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/ranger-hdfs-security.xml > a5f1e24 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-audit.xml > 874d0d5 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-policymgr-ssl.xml > 14e7b16 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-security.xml > 61e008f > > ambari-server/src/main/resources/stacks/HDP/2.3/services/KAFKA/configuration/ranger-kafka-policymgr-ssl.xml > 2f4c121 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/KNOX/configuration/ranger-knox-audit.xml > abdf2bd > > ambari-server/src/main/resources/stacks/HDP/2.3/services/KNOX/configuration/ranger-knox-policymgr-ssl.xml > 6cc2351 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/KNOX/configuration/ranger-knox-security.xml > 3b73bca > > ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-policymgr-ssl.xml > 21658e7 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-security.xml > 8a3dd2e > > ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/ranger-yarn-audit.xml > 8237f1c > > ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/ranger-yarn-plugin-properties.xml > 1899d44 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/ranger-yarn-policymgr-ssl.xml > 6ad6e62 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/ranger-yarn-security.xml > 6fe9f9e > > ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/yarn-site.xml > 5daa9fd > > ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/ranger-atlas-audit.xml > efeea5f > > ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/ranger-atlas-plugin-properties.xml > 2f1cd9e > > ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/ranger-atlas-policymgr-ssl.xml > 349c829 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/ranger-atlas-security.xml > 5c9f37c > > ambari-server/src/main/resources/stacks/HDP/2.5/services/FALCON/configuration/falcon-atlas-application.properties.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/configuration/ranger-hdfs-plugin-properties.xml > bf07b59 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/ranger-kms-audit.xml > 86b963b > > ambari-server/src/main/resources/stacks/HDP/2.5/services/STORM/configuration/ranger-storm-policymgr-ssl.xml > 21658e7 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/STORM/configuration/ranger-storm-security.xml > 8a3dd2e > > ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/configuration/yarn-site.xml > ea7a7af > > Diff: https://reviews.apache.org/r/50645/diff/ > > > Testing > ------- > > Manually run. > > ---------------------------------------------------------------------- > Ran 267 tests in 6.827s > > OK > ---------------------------------------------------------------------- > Total run:1035 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Sumit Mohanty > >
