-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50660/#review144484
-----------------------------------------------------------




ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
(lines 1023 - 1035)
<https://reviews.apache.org/r/50660/#comment210498>

    Previously, the existing SCH would be used to check the cache. Now, you 
need to get both the actual and desired configurations in order to calculate 
the hash just to check to see if the cache has the entry.
    
    This means that every heartbeat of every agent, every query, now has to 
make a JPQL hit against the database to get the data back.
    
    I think this could be destructive on larger deployments. 
    
    Previously, an existing object was used before making and queries into the 
DB.


- Jonathan Hurley


On Aug. 1, 2016, 12:16 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50660/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2016, 12:16 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Dmytro Sen, 
> and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-17979
>     https://issues.apache.org/jira/browse/AMBARI-17979
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> STR:
> ->On a RM HA Cluster, add a host. 
> ->Add ZK Server on that host. Wait for Restart indicators to appear 
> (Indicators appeared in test)
> ->Remove ZK Server from that host. Wait for Restart indicators to appear 
> (*Indicators did not appear until ~15 minutes after*). The test has 3 retries 
> to look for restart indicators with 40 seconds sleep in each.
> 
> Test logs with timestamps
> {code}
> 2016-07-26 12:49:15,479 INFO 
> com.hw.ambari.ui.opm.monitoring.pages.HostDetailsPage.selectAction(): Clicked 
> Action from comboBox with 
> xpath://ul[contains(@class,'dropdown-menu')]//li[not 
> (@class='hidden')]//a[span[text() ='Delete']]
> 2016-07-26 12:49:15,755 INFO com.hw.ambari.ui.opm.WebDriverHelper.confirm(): 
> Confirm Selected Operation..
> 2016-07-26 12:49:15,868 INFO 
> com.hw.ambari.ui.opm.elements.DialogWindow.clickConfirm(): Confirm Button 
> found
> 2016-07-26 12:49:17,985 INFO 
> com.hw.ambari.ui.opm.elements.DialogWindow.clickConfirm(): Confirm Button 
> found
> 2016-07-26 12:49:18,010 INFO 
> com.hw.ambari.ui.opm.elements.DialogWindow.clickConfirm(): Clicked Confirm 
> Button
> 2016-07-26 12:49:18,010 DEBUG 
> com.hw.ambari.ui.opm.WebDriverHelper.sleepSeconds(): Starting sleeping for 30 
> seconds...
> 2016-07-26 12:49:18,010 DEBUG 
> com.hw.ambari.ui.opm.WebDriverHelper.sleepSeconds(): Caller: 
> com.hw.ambari.ui.tests.monitoring.admin_page.TestEnableRmHa.deleteZookeeperServerFromExistingHost(TestEnableRmHa.java:620)
> {code}
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
>  f9ce8e6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  6e3eef7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java
>  3ba8e69 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> 16edc74 
>   ambari-server/src/main/java/org/apache/ambari/server/state/HostConfig.java 
> 0f451ce 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  53059dc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
>  78f3751 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProviderTest.java
>  2a4b949 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java
>  f3d35d9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java
>  44afdaa 
> 
> Diff: https://reviews.apache.org/r/50660/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Reply via email to