-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49935/#review144722
-----------------------------------------------------------


Ship it!




Ship It!

- Jayush Luniya


On Aug. 2, 2016, 12:11 a.m., Masahiro Tanaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49935/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2016, 12:11 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jayush 
> Luniya, Myroslav Papirkovskyy, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17633
>     https://issues.apache.org/jira/browse/AMBARI-17633
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When installing YARN+MapReduce2, I got a WARN message in nodemanager log(in 
> Log Search View) like below
> ```
> 2016-07-09 06:30:21,865 WARN logaggregation.LogAggregationService 
> LogAggregationService.java:230 - Remote Root Log Dir [/app-logs] already 
> exist, but with incorrect permissions. Expected: [rwxrwxrwt], Found: 
> [rwxrwxrwx]. The cluster may have problems with multiple users. 
> ```
> I think the cause of this WARN is 
> [this](https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py#L115).
> We should add stickybit to yarn.nodemanager.remote-app-log-dir.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
>  cf5736e 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 
> 4600063 
> 
> Diff: https://reviews.apache.org/r/49935/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test && manual test
> 
> +1 overall. Here are the results of testing the latest attachment
> http://issues.apache.org/jira/secure/attachment/12817505/AMBARI-17633.2.patch
> against trunk revision .
> 
> +1 @author. The patch does not contain any @author tags.
> 
> +1 tests included. The patch appears to include 1 new or modified test files.
> 
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> 
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> 
> +1 core tests. The patch passed unit tests in ambari-server.
> 
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7805//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7805//console
> 
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Reply via email to