> On Aug. 4, 2016, 1:14 p.m., Gaurav Nagar wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java,
> >  line 559
> > <https://reviews.apache.org/r/50790/diff/1/?file=1462817#file1462817line559>
> >
> >     This will execute on all entity tables. Is this required?

No it is not required. Nice catch. Will fix it and upload new patch.


- Nitiraj


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50790/#review144755
-----------------------------------------------------------


On Aug. 4, 2016, 6:14 p.m., Nitiraj Rathore wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50790/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2016, 6:14 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-18018
>     https://issues.apache.org/jira/browse/AMBARI-18018
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> added upgrade code to update the timestamps from seconds to miliseconds as 
> expected in currently.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  4bc1a81 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  25fd423 
> 
> Diff: https://reviews.apache.org/r/50790/diff/
> 
> 
> Testing
> -------
> 
> manual testing of upgrade from previous version done
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Reply via email to