----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50450/#review144846 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java (line 3338) <https://reviews.apache.org/r/50450/#comment210985> Since we have only one element, can we directly get it instead of using a for loop to get the only element? - Nahappan Somasundaram On Aug. 4, 2016, 12:05 p.m., Ajit Kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50450/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2016, 12:05 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Zhe (Joe) Wang, Nate Cole, > Nahappan Somasundaram, and Sumit Mohanty. > > > Bugs: AMBARI-18011 > https://issues.apache.org/jira/browse/AMBARI-18011 > > > Repository: ambari > > > Description > ------- > > API for bulk delete hostcomponent. > This should do best effort to delete hostcomponents. Current implementation > fails fast in case of error. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/HostComponentService.java > 4990ad71c7dbd0d64ea7e817ace278aea8fe0f1d > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java > 5cf2de7b95939c9a55c5506988b2a6ba6801936c > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 075b85a806fc5de8552f605a858ad153d7e485c6 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java > df2b476ee030e8de88300e04ecaf08f46cbcfc4d > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > 3ad1f1fc7702b60d832e3819829ffd71c30e08f3 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java > ef1b821ca05a563f0dbb3058877d335015bc6370 > > Diff: https://reviews.apache.org/r/50450/diff/ > > > Testing > ------- > > Unit test > Manual Test > delete http://c6401.ambari.apache.org:8080/api/v1/clusters/c1/host_components > -d > '{"RequestInfo":{"query":"HostRoles/host_name.in(c6401.ambari.apache.org,c6402.ambari.apache.org)"}}' > > Response : http://pastebin.com/GADF2ncH > > > Thanks, > > Ajit Kumar > >
