-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50850/#review144973
-----------------------------------------------------------


Fix it, then Ship it!




Thanks for making the changes and ading the unit tests.


ambari-server/src/main/java/org/apache/ambari/server/api/DateJsonDeserializer.java
 (line 51)
<https://reviews.apache.org/r/50850/#comment211128>

    Java coding standands dictate that `enUsFormat` should be something like 
`EN_US_FORMAT` since it is a `static final` member variable.



ambari-server/src/main/java/org/apache/ambari/server/api/DateJsonDeserializer.java
 (line 56)
<https://reviews.apache.org/r/50850/#comment211129>

    Java coding standands dictate that `localFormat` should be something like 
`LOCAL_FORMAT` since it is a `static final` member variable.


- Robert Levas


On Aug. 5, 2016, 2:19 p.m., Gaurav Nagar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50850/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2016, 2:19 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, Rohit Choudhary, Robert Levas, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-18045
>     https://issues.apache.org/jira/browse/AMBARI-18045
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Added date deserializer for parsing epoch time.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/DateJsonDeserializer.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/GsonJsonProvider.java
>  8ba9ff7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/TestDateDeserializer.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50850/diff/
> 
> 
> Testing
> -------
> 
> Manually Tested
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Reply via email to