-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50924/
-----------------------------------------------------------
(Updated Aug. 9, 2016, 11:42 a.m.)
Review request for Ambari, Hayat Behlim, Dharmesh Makwana, Oliver Szabo, Sumit
Mohanty, and Hemanth Yamijala.
Changes
-------
Remove dependency to commons-lang to keep this component as small as possible.
Bugs: AMBARI-18077
https://issues.apache.org/jira/browse/AMBARI-18077
Repository: ambari
Description (updated)
-------
Log Search appender is a bit messy and it also uses reflection to which is slow
for something as heavily used as a log appender.
- Removed superfluous base class VBase
- Renamed VOutput to Output
- Removed superfluous getters
- Replaced reflection based json creating Gson with JsonWriter which made it
10x faster
Diffs (updated)
-----
ambari-logsearch/ambari-logsearch-appender/pom.xml 39f250a
ambari-logsearch/ambari-logsearch-appender/src/main/java/org/apache/ambari/logsearch/appender/LogsearchConversion.java
dbdfe6c
ambari-logsearch/ambari-logsearch-appender/src/main/java/org/apache/ambari/logsearch/appender/Output.java
PRE-CREATION
ambari-logsearch/ambari-logsearch-appender/src/main/java/org/apache/ambari/logsearch/appender/VBase.java
4e91ccc
ambari-logsearch/ambari-logsearch-appender/src/main/java/org/apache/ambari/logsearch/appender/VOutput.java
61da1da
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractStateFileZkCommand.java
664cd88
Diff: https://reviews.apache.org/r/50924/diff/
Testing
-------
Tested on local cluster.
Thanks,
Miklos Gergely
