-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50929/#review145242
-----------------------------------------------------------


Ship it!




Ship It!

- Sumit Mohanty


On Aug. 9, 2016, 7:03 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50929/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2016, 7:03 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Venkat 
> Ranganathan.
> 
> 
> Bugs: AMBARI-18086
>     https://issues.apache.org/jira/browse/AMBARI-18086
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Several changes for Falcon Atlas integration.
> 
> In Falcon's params_linux.py for HDP 2.5, set atlas_hook_cp even if Atlas is 
> not present on this host since the RPM will install the dependency if Falcon 
> is installed. 
> {code}
> atlas_hook_cp = ""
> if has_atlas_in_cluster():
>   atlas_hook_filename = 
> default('/configurations/atlas-env/metadata_conf_file', 
> 'atlas-application.properties')
> 
>   # Only append /etc/atlas/conf to classpath if on HDP 2.4.* and atlas server 
> is running on this host.
>   if has_atlas_server_on_host and 
> check_stack_feature(StackFeature.ATLAS_CONF_DIR_IN_PATH, 
> stack_version_formatted):
>     atlas_conf_dir = os.environ['METADATA_CONF'] if 'METADATA_CONF' in 
> os.environ else format('{stack_root}/current/atlas-server/conf')
>     atlas_home_dir = os.environ['METADATA_HOME_DIR'] if 'METADATA_HOME_DIR' 
> in os.environ else format('{stack_root}/current/atlas-server')
>     atlas_hook_cp = atlas_conf_dir + os.pathsep + 
> os.path.join(atlas_home_dir, "hook", "falcon", "*") + os.pathsep
> #endregion
> {code}
> 
> Further, Stack Advisor in HDP 2.5, plus EU/RU to HDP 2.5 needs to change 
> Falcon's falcon-startup.properties "*.application.services" to use 
> "org.apache.atlas.falcon.service.AtlasService" instead of 
> "org.apache.falcon.atlas.service.AtlasService" since the class was renamed.
> 
> 
> Diffs
> -----
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py
>  a8b5827 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  a3a4e54 
> 
> Diff: https://reviews.apache.org/r/50929/diff/
> 
> 
> Testing
> -------
> 
> [21:40:20] Andrii Voloshyn: [INFO] Rat check: Summary of files. Unapproved: 0 
> unknown: 0 generated: 0 approved: 148 licence.
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Server ..................................... SUCCESS [1:39.115s]
> [INFO] Ambari Agent ...................................... SUCCESS [30.376s]
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time: 2:10.248s
> [INFO] Finished at: Tue Aug 09 21:39:29 EEST 2016
> mvn clean test -pl ambari-agent,ambari-server -Dmaven.test.skip=true
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Reply via email to