> On Aug. 10, 2016, 7:18 p.m., Sid Wagle wrote:
> > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/hadoop-metrics2-hbase.properties.j2,
> >  line 58
> > <https://reviews.apache.org/r/50927/diff/1/?file=1469085#file1469085line58>
> >
> >     Why this change only in hbase properties?

Removed hadoop-metrics2*.properties changes. Tracked as a different issue.


- Aravindan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50927/#review145388
-----------------------------------------------------------


On Aug. 10, 2016, 7:51 p.m., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50927/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2016, 7:51 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18012
>     https://issues.apache.org/jira/browse/AMBARI-18012
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Following exception is seen in the logs
> 
> Unable to connect to zookeeper.
> java.lang.IllegalStateException: Client is not started
>         at 
> org.apache.hadoop.metrics2.sink.relocated.google.common.base.Preconditions.checkState(Preconditions.java:149)
>         at 
> org.apache.hadoop.metrics2.sink.relocated.curator.CuratorZookeeperClient.getZooKeeper(CuratorZookeeperClient.java:113)
>         at 
> org.apache.hadoop.metrics2.sink.timeline.availability.MetricCollectorHAHelper$1.call(MetricCollectorHAHelper.java:77)
>         at 
> org.apache.hadoop.metrics2.sink.timeline.availability.MetricCollectorHAHelper$1.call(MetricCollectorHAHelper.java:74)
>         at 
> org.apache.hadoop.metrics2.sink.relocated.curator.RetryLoop.callWithRetry(RetryLoop.java:107)
>         at 
> org.apache.hadoop.metrics2.sink.timeline.availability.MetricCollectorHAHelper.findLiveCollectorHostsFromZNode(MetricCollectorHAHelper.java:74)
>         at 
> org.apache.hadoop.metrics2.sink.timeline.AbstractTimelineMetricsSink.findPreferredCollectHost(AbstractTimelineMetricsSink.java:363)
>         at 
> org.apache.hadoop.metrics2.sink.timeline.AbstractTimelineMetricsSink.emitMetrics(AbstractTimelineMetricsSink.java:209)
>         at 
> org.apache.hadoop.metrics2.sink.timeline.HadoopTimelineMetricsSink.putMetrics(HadoopTimelineMetricsSink.java:315)
>         at 
> org.apache.hadoop.metrics2.impl.MetricsSinkAdapter.consume(MetricsSinkAdapter.java:186)
>         at 
> org.apache.hadoop.metrics2.impl.MetricsSinkAdapter.consume(MetricsSinkAdapter.java:43)
>         at 
> org.apache.hadoop.metrics2.impl.SinkQueue.consumeAll(SinkQueue.java:87)
>         at 
> org.apache.hadoop.metrics2.impl.MetricsSinkAdapter.publishMetricsFromQueue(MetricsSinkAdapter.java:134)
>         at 
> org.apache.hadoop.metrics2.impl.MetricsSinkAdapter$1.run(MetricsSinkAdapter.java:88)
> 
> 
> FIX
> Fixed the issue in curator API usage.
> Also fixed an issue due to redundant protocol addition in the URL for AMS 
> metrics.
> 
> 
> Diffs
> -----
> 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/availability/MetricCollectorHAHelper.java
>  7b13362 
> 
> Diff: https://reviews.apache.org/r/50927/diff/
> 
> 
> Testing
> -------
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Reply via email to