----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50953/#review145513 -----------------------------------------------------------
Ship it! Ship It! - Nate Cole On Aug. 11, 2016, 11 a.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50953/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2016, 11 a.m.) > > > Review request for Ambari, Jonathan Hurley and Nate Cole. > > > Bugs: AMBARI-18118 > https://issues.apache.org/jira/browse/AMBARI-18118 > > > Repository: ambari > > > Description > ------- > > Existing code basically does that: > takes all config versions that ever existed, iterates them in random order, > and the config that happened to be last gets into final configuration > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/agent/AlertDefinitionCommand.java > fdd7f1d > > ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertDefinitionHashTest.java > 74a349c > > Diff: https://reviews.apache.org/r/50953/diff/ > > > Testing > ------- > > tested on live cluster > unit tests in progress > > > Thanks, > > Dmitro Lisnichenko > >
