> On Aug. 14, 2016, 3:06 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml,
> >  line 76
> > <https://reviews.apache.org/r/51078/diff/1/?file=1472666#file1472666line76>
> >
> >     Can you open a next release JIRA to set all these properties as not to 
> > be added on ambari upgrade? Its ok for now.
> 
> Jeff Zhang wrote:
>     Why not adding them on ambari upgrade ? Any concern for that ?
> 
> Sumit Mohanty wrote:
>     Spark 2.0.0 is added for the first time in Ambari-2.4.0. Where do you see 
> a scenario when you want these properties get added during Ambari upgrade? If 
> spark 2.0 exists it will include these properties. If not they will get added 
> when Spark2 is added.

Not sure what the side effect of adding this. I notice all the property of 
spark2 has this on-ambari-upgrade setting. If this is not correct, then we 
should remove this for all the properties.


- Jeff


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51078/#review145724
-----------------------------------------------------------


On Aug. 14, 2016, 3:45 a.m., Jeff Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51078/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2016, 3:45 a.m.)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18142
>     https://issues.apache.org/jira/browse/AMBARI-18142
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Should define keytab/principle for spark thrift server in its configuration 
> file 'spark-thrift-sparkconf'
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/configuration/spark-env.xml
>  832a8f5 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
>  e38316b 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/spark_service.py
>  704af68 
>   ambari-server/src/main/resources/common-services/SPARK/1.4.1/kerberos.json 
> 21ba259 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml
>  5a3edef 
>   ambari-server/src/main/resources/common-services/SPARK2/2.0.0/kerberos.json 
> 3aafb75 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py
>  c89a302 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_service.py
>  834871d 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/kerberos.json 
> ea2cf52 
> 
> Diff: https://reviews.apache.org/r/51078/diff/
> 
> 
> Testing
> -------
> 
> Tested manually.
> 
> 
> Thanks,
> 
> Jeff Zhang
> 
>

Reply via email to