-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51158/#review145944
-----------------------------------------------------------


Ship it!




Ship It!

- Sid Wagle


On Aug. 16, 2016, 11:57 p.m., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51158/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2016, 11:57 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18170
>     https://issues.apache.org/jira/browse/AMBARI-18170
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> No kafka metrics are seen in trunk deployments.
> 
> ISSUE
> Kafka was configured to work only with one collector. It was not passed the 
> list of metric_collector_host:port information which is needed for the Sink 
> to work.
> 
> 
> Diffs
> -----
> 
>   
> ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java
>  11a1c75 
>   
> ambari-metrics/ambari-metrics-kafka-sink/src/test/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporterTest.java
>  9027716 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml
>  f7da62c 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py
>  ac7b0ae 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
>  19f8e0f 
>   ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-upgrade.json 
> cfff7df 
>   
> ambari-server/src/test/python/stacks/2.2/configs/ranger-usersync-upgrade.json 
> 4cda2a4 
>   ambari-web/app/assets/data/stacks/HDP-2.2/configurations.json 85d4a9f 
> 
> Diff: https://reviews.apache.org/r/51158/diff/
> 
> 
> Testing
> -------
> 
> Manually tested.
> 
> Unit tests pass.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Reply via email to