> On Aug. 17, 2016, 1:26 a.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py,
> >  line 337
> > <https://reviews.apache.org/r/51121/diff/3/?file=1475926#file1475926line337>
> >
> >     Andrew, I had to modify this since recursive_chown show=True should 
> > still execute the rest of this function to forcibly set the owner.

Okay got it. There is a couple of points I wanted to discuss on this change.
1. That will be a major slow down for starts unfortunately. Since we will have 
to wait until chown for every single file in tree is done. On every start. 
(hmbldt work we do needs good timing)
2. We had cstmrs complaining about Ambari changing hdfs permissions especially 
recusively (see AMBARI-15228). Is that possible to avoid doing it somehow in 
scope of this problem?
     
Just from the point of code doing something like would be more logical imo 
(refactored yours):
     group = "" if not self.main_resource.resource.group else 
self.main_resource.resource.group
     
     if (not owner or file_status and file_status['owner'] == owner) and (not 
group or file_status and file_status['group'] == group):
       self.util.run_command(self.main_resource.resource.target, 'SETOWNER', 
method='PUT', owner=owner, group=group, assertable_result=False)
     
     results = []
     ... do what before ...
     
However its just refactoring won't solve the points above.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51121/#review145946
-----------------------------------------------------------


On Aug. 17, 2016, 1 a.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51121/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2016, 1 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Sumit Mohanty, and Venkat 
> Ranganathan.
> 
> 
> Bugs: AMBARI-18151
>     https://issues.apache.org/jira/browse/AMBARI-18151
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Whenever Oozie submits Hive actions, they fail and the application logs show 
> "Internal Error: 
> java.lang.ClassNotFoundException(org.apache.atlas.hive.hook.HiveHook"
> 
> This is because whenever Atlas is installed, the Hive Hook (which is 
> installed via the Oozie RPM too, in /usr/$stack/$version/atlas/hook/hive/) 
> needs to be copied to the Oozie Share lib in HDFS (e.g., 
> hdfs:///user/oozie/share/lib/lib_$timestamp/hive)
> 
> Further, need to save atlas-application.properties used for Hive to 
> hdfs:///user/oozie/share/lib/lib_$timestamp/hive/
> 
> Lastly, remove the atlas.rest.address property from hive-site.xml
> 
> 
> Diffs
> -----
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  c5cbb3f 
>   
> ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py
>  7abdf5c 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
>  dd3a692 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py
>  e330cb5 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  db048bb 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  ed995b2 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-site.xml
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51121/diff/
> 
> 
> Testing
> -------
> 
> Verified on a live cluster with HDP 2.5 and Oozie, Hive, Atlas
> 
> Python unit tests passed,
> 
> OK
> ----------------------------------------------------------------------
> Total run:1034
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Reply via email to