----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50995/#review145539 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java (line 31) <https://reviews.apache.org/r/50995/#comment211796> Add javadoc for what this class does. ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsServiceImpl.java (line 47) <https://reviews.apache.org/r/50995/#comment211798> Add javadoc - Alejandro Fernandez On Aug. 18, 2016, 6:03 p.m., Li-Wei Tseng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50995/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2016, 6:03 p.m.) > > > Review request for Ambari and Aravindan Vijayan. > > > Bugs: AMBARI-17591 > https://issues.apache.org/jira/browse/AMBARI-17591 > > > Repository: ambari > > > Description > ------- > > Created metrics service which has a JVM metrics source and a sink. The JVM > metrics source collect JVM metrics and pass it to the sink which then publish > the metrics to AMS > > > Diffs > ----- > > ambari-server/conf/unix/metrics.properties PRE-CREATION > ambari-server/pom.xml 0d91458 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > 097f01c > > ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java > 256f0d1 > > ambari-server/src/main/java/org/apache/ambari/server/metrics/system/AmbariMetricSink.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsService.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsSource.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AbstractMetricsSource.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/Configuration.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/JvmMetricsSource.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsServiceImpl.java > PRE-CREATION > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/default/grafana-ambari-server.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/50995/diff/ > > > Testing > ------- > > Manually tested it. > > > Thanks, > > Li-Wei Tseng > >
