-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51289/#review146365
-----------------------------------------------------------


Ship it!




Ship It!

one thing:
you can use @TestSubject and @Mock annotations from EasyMock, instead of create 
an applicationContext for tests with junit runner. in that case it would be 
real unit tests, not functional tests

- Oliver Szabo


On Aug. 22, 2016, 2:57 p.m., Miklos Gergely wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51289/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2016, 2:57 p.m.)
> 
> 
> Review request for Ambari, Hayat Behlim, Dharmesh Makwana, Oliver Szabo, and 
> Robert Nettleton.
> 
> 
> Bugs: AMBARI-18227
>     https://issues.apache.org/jira/browse/AMBARI-18227
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Dao and common package are covered with unit tests now.
> 
> Cleanup done:
> 
> - maximum line length is 120 now
> - ManageStartEndTime fixed (it may have returned an invalid time range if it 
> was asked right between updating the window)
> - fix setupCollectionsWithImplicitRouting, maxShardsPerNode were set twice 
> instead of numShards and maxShardsPerNode
> - RequestContext was removed as it was never used only in UserDao, the 
> constants were moved there too
> - UserSessionInfo was removed as it contained only one field, and 
> getter/setter for it.
> - LogSearchContext was introduced by merging LogsearchContextUtil, 
> UserSessionInfo, LogsearchContextHolder, LogsearchSecurityContext
> - UserInfoAttributes was removed as it contained only constants which were 
> used in 
> - removed the class org.apache.ambari.logsearch.util.StringUtil, 
> org.apache.commons.lang.StringUtils is used instead
> - StringUtils, ArrayUtils and CollectionUtils are used at various locations
> - java naming conventions enforced
> - visibilities fixed
> - unused codes removed
> - handle constants as constants
> 
> 
> Diffs
> -----
> 
>   ambari-logsearch/ambari-logsearch-portal/pom.xml a886b37 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/LogSearch.java
>  d1fbcde 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/LogSearchConstants.java
>  5dcdac1 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/LogSearchContext.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/LogsearchContextUtil.java
>  617f2fd 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/ManageStartEndTime.java
>  94b7159 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/MessageEnums.java
>  59e698f 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/RequestContext.java
>  83ed3bd 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/SearchCriteria.java
>  d0facbc 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/UserSessionInfo.java
>  78fea31 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/AuditSolrDao.java
>  5a56ad7 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/ServiceLogsSolrDao.java
>  5aba6d1 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java
>  cda5e26 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java
>  e612475 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserDao.java
>  6b2f049 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserInfoAttributes.java
>  7bc3555 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/graph/GraphDataGenerator.java
>  d3975b3 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/graph/GraphDataGeneratorBase.java
>  a813e96 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/AuditMgr.java
>  ab287bc 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/LogFileMgr.java
>  1bd9a78 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/LogsMgr.java
>  257f04d 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/MgrBase.java
>  99eb9f2 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/PublicMgr.java
>  0dccb74 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/SessionMgr.java
>  dbc14e1 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/UserConfigMgr.java
>  c4fbd9f 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/query/QueryGeneration.java
>  d934e84 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/query/QueryGenerationBase.java
>  a128098 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/ServiceLogsREST.java
>  373f7ff 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/security/context/LogsearchContextHolder.java
>  fb23cde 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/security/context/LogsearchSecurityContext.java
>  4a79525 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/BizUtil.java
>  8dd0fb9 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/CommonUtil.java
>  320e589 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/ConfigUtil.java
>  2661150 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/DateUtil.java
>  7425aaa 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/FileUtil.java
>  658635c 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/JSONUtil.java
>  4703c58 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/LogsearchPropertiesConfiguration.java
>  c3ef20f 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/PropertiesUtil.java
>  16ebae2 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/QueryBase.java
>  d1e0a86 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/RESTErrorUtil.java
>  e64f742 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/SolrUtil.java
>  ee706bf 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/StringUtil.java
>  de83e7e 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchSecurityContextFormationFilter.java
>  69132e8 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchExternalServerAuthenticationProvider.java
>  f1f2e31 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchFileAuthenticationProvider.java
>  a5ff295 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchSimpleAuthenticationProvider.java
>  7e0546e 
>   
> ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/common/LogSearchContextUtilTest.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/common/ManageStartEndTimeTest.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/dao/AuditSolrDaoTest.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/dao/ServiceLogsSolrDaoTest.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/dao/SolrDaoBaseTest.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/dao/UserConfigSolrDaoTest.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/dao/UserDaoTest.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/test/resources/HadoopServiceConfig.json
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/test/resources/applicationContext.xml
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/test/resources/applicationContext_testManagers.xml
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/test/resources/logsearch.properties
>  PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-portal/src/test/resources/user_pass.json 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51289/diff/
> 
> 
> Testing
> -------
> 
> done
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Reply via email to