----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51280/#review146376 -----------------------------------------------------------
Ship it! Ship It! - Jayush Luniya On Aug. 22, 2016, 5:52 a.m., Jaimin Jetly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51280/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2016, 5:52 a.m.) > > > Review request for Ambari and Yusaku Sako. > > > Bugs: AMBARI-18224 > https://issues.apache.org/jira/browse/AMBARI-18224 > > > Repository: ambari > > > Description > ------- > > Some of the images get missing from Ambari ui when SSL is enabled. > This issue only happens in Chrome. ( Tested with Version 52.0.2743.116 > (64-bit)) > > This issue happens on 2.4.o buut is not seen on 2.2.2 GA > > some of the known differences between both is in jetty version, jersey > version and jsr version > > Also another noticeable difference is the Request header ""Accept Encoding" > > Request Header "Accept Encoding" for 2.4.0 while making image requests is set > to "gzip, deflate, sdch, br" > > > Diffs > ----- > > ambari-web/pom.xml ca75fe3 > > Diff: https://reviews.apache.org/r/51280/diff/ > > > Testing > ------- > > Tesetd that gzip on png images resolves the issue on a cluster. > verified that wth the fix mvn packge command on ambar-web project gzips all > png images. > > Verified that ambari-web unit test passes with the fix: > > 29244 tests complete (28 seconds) > 154 tests pending > > > Thanks, > > Jaimin Jetly > >
