> On Aug. 22, 2016, 7:33 p.m., Nate Cole wrote: > > Just confirm with Alejandro why he had both a field and a value.
One was a boolean to read from the XML file, and the other is the actual calculation by reading from the parent if the XML file did not explicitly provide a value. - Alejandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51296/#review146414 ----------------------------------------------------------- On Aug. 22, 2016, 6:25 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51296/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2016, 6:25 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate > Cole. > > > Bugs: AMBARI-18231 > https://issues.apache.org/jira/browse/AMBARI-18231 > > > Repository: ambari > > > Description > ------- > > Noticed in the stack deploy runs: > {code} > 20 Aug 2016 11:20:07,519 ERROR [ambari-heartbeat-processor-0] > StackVersionListener:116 - ServiceComponent {0} doesn't advertise version, > however ServiceHostComponent ATLAS_SERVER on host ATLAS_SERVER advertised > version as host. Skipping version update > {code} > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java > 87247eb > > ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java > 537ae32 > > ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java > 2dae526 > > ambari-server/src/test/java/org/apache/ambari/server/stack/ComponentModuleTest.java > 905707c > > Diff: https://reviews.apache.org/r/51296/diff/ > > > Testing > ------- > > on live cluster > unit test run in progress > > > Thanks, > > Dmitro Lisnichenko > >
