-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49802/#review146596
-----------------------------------------------------------




ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
 (line 283)
<https://reviews.apache.org/r/49802/#comment213116>

    use "is None" instead
    Or better yet, have a try-catch in which if the value is None, "", negative 
interger, etc. then the default value is 10
    
    Under which conditions is this missing?
    In other words, what is upstream that is causing this to fail?


- Alejandro Fernandez


On Aug. 24, 2016, 12:18 a.m., wang yaoxin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49802/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2016, 12:18 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, JaimejucoummaUW 
> JaimejucoummaUW, and Kuldeep Mishra.
> 
> 
> Bugs: AMBARI-17546
>     https://issues.apache.org/jira/browse/AMBARI-17546
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> the host view ,excute namenode rebalance HDFS, json none lead fail
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
>  df02311 
> 
> Diff: https://reviews.apache.org/r/49802/diff/
> 
> 
> Testing
> -------
> 
> done
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>

Reply via email to