-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51360/#review146656
-----------------------------------------------------------


Ship it!




Ship It!

- Tim Thorpe


On Aug. 24, 2016, 3:16 a.m., Ying Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51360/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2016, 3:16 a.m.)
> 
> 
> Review request for Ambari and Tim Thorpe.
> 
> 
> Bugs: AMBARI-17999
>     https://issues.apache.org/jira/browse/AMBARI-17999
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In Ambari code, property name "yarn.nodemanager.log.retain-second" is wrong. 
> It should be "yarn.nodemanager.log.retain-seconds" instead, which is the 
> property name being looked up in Hadoop code.
> 
> 
> Diffs
> -----
> 
>   
> ambari-funtest/src/test/resources/stacks/HDP/2.0.1/services/YARN/configuration/yarn-site.xml
>  da6641f 
>   
> ambari-funtest/src/test/resources/stacks/HDP/2.0.5/services/YARN/configuration/yarn-site.xml
>  87ce416 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-site.xml
>  bf89165 
>   
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/YARN/configuration/yarn-site.xml
>  452bdd8 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6.GlusterFS/services/YARN/configuration/yarn-site.xml
>  49502ad 
>   
> ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/YARN/configuration/yarn-site.xml
>  49502ad 
>   
> ambari-server/src/main/resources/upgrade/catalog/UpgradeCatalog_1.3_to_2.2.json
>  d2d059e 
>   ambari-server/src/test/python/stacks/2.0.6/configs/altfs_plus_hdfs.json 
> ff78609 
>   ambari-server/src/test/python/stacks/2.0.6/configs/client-upgrade.json 
> 47ab0a3 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.hbasedecom.json 
> f8d9b21 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json 28624fd 
>   
> ambari-server/src/test/python/stacks/2.0.6/configs/default.non_gmetad_host.json
>  26dc966 
>   
> ambari-server/src/test/python/stacks/2.0.6/configs/default_ams_embedded.json 
> e9365a0 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_client.json 
> d5f9d19 
>   
> ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_non_hdfs.json 
> 3692691 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_no_install.json 
> 08b57d7 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_oozie_mysql.json 
> c4b5722 
>   
> ambari-server/src/test/python/stacks/2.0.6/configs/default_update_exclude_file_only.json
>  79f0f86 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_with_bucket.json 
> 54172f3 
>   ambari-server/src/test/python/stacks/2.0.6/configs/flume_22.json d9bc7f9 
>   ambari-server/src/test/python/stacks/2.0.6/configs/flume_target.json 
> a23b313 
>   
> ambari-server/src/test/python/stacks/2.0.6/configs/ha_bootstrap_active_node.json
>  cfd5b17 
>   
> ambari-server/src/test/python/stacks/2.0.6/configs/ha_bootstrap_standby_node.json
>  ee88983 
>   
> ambari-server/src/test/python/stacks/2.0.6/configs/ha_bootstrap_standby_node_initial_start.json
>  b685773 
>   
> ambari-server/src/test/python/stacks/2.0.6/configs/ha_bootstrap_standby_node_initial_start_dfs_nameservices.json
>  0ea8b16 
>   ambari-server/src/test/python/stacks/2.0.6/configs/ha_default.json e605c05 
>   ambari-server/src/test/python/stacks/2.0.6/configs/ha_secured.json bf815a2 
>   ambari-server/src/test/python/stacks/2.0.6/configs/hbase-2.2.json c79d029 
>   ambari-server/src/test/python/stacks/2.0.6/configs/hbase-check-2.2.json 
> 555c160 
>   
> ambari-server/src/test/python/stacks/2.0.6/configs/hbase-rs-2.2-phoenix.json 
> 44db842 
>   ambari-server/src/test/python/stacks/2.0.6/configs/hbase-rs-2.2.json 
> 58827ae 
>   ambari-server/src/test/python/stacks/2.0.6/configs/oozie_existing_sqla.json 
> 65a14a6 
>   
> ambari-server/src/test/python/stacks/2.0.6/configs/rebalancehdfs_default.json 
> d9e3a9e 
>   
> ambari-server/src/test/python/stacks/2.0.6/configs/rebalancehdfs_secured.json 
> 597fe94 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured.json 9ce2624 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured_client.json 
> 48e9756 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured_no_jce_name.json 
> 3eac379 
>   ambari-server/src/test/python/stacks/2.1/configs/client-upgrade.json 
> 170edd8 
>   ambari-server/src/test/python/stacks/2.1/configs/default.json 7c33c52 
>   ambari-server/src/test/python/stacks/2.1/configs/secured.json a2af06a 
>   
> ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade-hdfs-secure.json
>  7b07d87 
>   ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade.json 
> cf84bb7 
>   
> ambari-server/src/test/python/stacks/2.2/configs/pig-service-check-secure.json
>  729ce78 
>   ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-upgrade.json 
> 6874db5 
>   
> ambari-server/src/test/python/stacks/2.2/configs/ranger-usersync-upgrade.json 
> 0f5d647 
>   ambari-server/src/test/python/stacks/2.3/common/services-sparkts-hive.json 
> 20a672e 
>   ambari-server/src/test/python/stacks/2.3/common/services-sparkts.json 
> f41944b 
>   ambari-server/src/test/python/stacks/2.3/configs/ats_1_5.json c64ca14 
>   ambari-server/src/test/python/stacks/2.3/configs/default.hbasedecom.json 
> fff0024 
>   ambari-server/src/test/python/stacks/2.5/configs/hsi_default.json 78a0d04 
>   ambari-server/src/test/resources/deploy_HDP2.sh e9a9396 
>   
> ambari-server/src/test/resources/stacks/HDP/2.0.1/services/YARN/configuration/yarn-site.xml
>  25b9841 
>   
> ambari-server/src/test/resources/stacks/HDP/2.0.5/services/YARN/configuration/yarn-site.xml
>  d2111d7 
>   ambari-web/app/assets/data/configurations/config_versions.json c9af200 
>   ambari-web/app/assets/data/stacks/HDP-2.2/configurations.json e0aa9eb 
>   ambari-web/app/assets/data/wizard/stack/hdp/version2.0.1/YARN.json acba00b 
>   ambari-web/app/data/BIGTOP/site_properties.js a52e6a6 
>   ambari-web/app/data/HDP2/site_properties.js 1fad1d6 
>   contrib/views/slider/src/main/resources/ui/app/assets/data/apps/apps.json 
> 23423d8 
>   
> contrib/views/slider/src/main/resources/ui/app/assets/data/resource/slider-properties.json
>  4b55dfa 
> 
> Diff: https://reviews.apache.org/r/51360/diff/
> 
> 
> Testing
> -------
> 
> Have run "mvn clean install" locally. There is one test failure with  
> "org.apache.hadoop.yarn.server.applicationhistoryservice.webapp.TestAHSWebApp.testAboutPage",
>  seems not related.
> 
> 
> Thanks,
> 
> Ying Zhang
> 
>

Reply via email to